Create a UKM descriptions XML file

Create a UKM descriptions XML file

BUG=678682
Review-Url: https://codereview.chromium.org/2769223005
Cr-Commit-Position: refs/heads/master@{#461784}
Committed: https://chromium.googlesource.com/chromium/src/+/deb93492c3c6ea9aaa2aecd6491dec38b4b722b0

[Steven Holte, 2017-03-25 00:10:50]

holte@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2017-03-30 01:26:20]

sorry for delay

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/common/mo...
File tools/metrics/common/models.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/common/mo...
tools/metrics/common/models.py:78: single_line: True iff this node may be
squashed into a single line.
add alpha comment

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/PRESU...
File tools/metrics/ukm/PRESUBMIT.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/PRESU...
tools/metrics/ukm/PRESUBMIT.py:15: p = f.AbsoluteLocalPath()
optional, put ukm.xml as a const

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/model.py
File tools/metrics/ukm/model.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/model...
tools/metrics/ukm/model.py:4: # """Model objects for rappor.xml contents."""
update

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/model...
tools/metrics/ukm/model.py:15: # Model definitions for rappor.xml content
+here

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/prett...
File tools/metrics/ukm/pretty_print.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/prett...
tools/metrics/ukm/pretty_print.py:5: 
remove log import

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/prett...
File tools/metrics/ukm/pretty_print_test.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/prett...
tools/metrics/ukm/pretty_print_test.py:5: 
update this file since it's not really testing anything.

[Steven Holte, 2017-03-30 22:42:23]

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/common/mo...
File tools/metrics/common/models.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/common/mo...
tools/metrics/common/models.py:78: single_line: True iff this node may be
squashed into a single line.
On 2017/03/30 01:26:20, rkaplow (slow) wrote:
> add alpha comment

Done.

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/PRESU...
File tools/metrics/ukm/PRESUBMIT.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/PRESU...
tools/metrics/ukm/PRESUBMIT.py:15: p = f.AbsoluteLocalPath()
On 2017/03/30 01:26:20, rkaplow (slow) wrote:
> optional, put ukm.xml as a const 

Done.

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/model.py
File tools/metrics/ukm/model.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/model...
tools/metrics/ukm/model.py:4: # """Model objects for rappor.xml contents."""
On 2017/03/30 01:26:20, rkaplow (slow) wrote:
> update

Done.

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/model...
tools/metrics/ukm/model.py:15: # Model definitions for rappor.xml content
On 2017/03/30 01:26:20, rkaplow (slow) wrote:
> +here

Done.

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/prett...
File tools/metrics/ukm/pretty_print.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/prett...
tools/metrics/ukm/pretty_print.py:5: 
On 2017/03/30 01:26:20, rkaplow (slow) wrote:
> remove log import

Done.

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/prett...
File tools/metrics/ukm/pretty_print_test.py (right):

https://codereview.chromium.org/2769223005/diff/20001/tools/metrics/ukm/prett...
tools/metrics/ukm/pretty_print_test.py:5: 
On 2017/03/30 01:26:20, rkaplow (slow) wrote:
> update this file since it's not really testing anything. 

Done.

[rkaplow, 2017-04-03 03:12:50]

rkaplow@chromium.org changed reviewers:
+ asvitkine@chromium.org

[rkaplow, 2017-04-03 03:12:51]

lgtm

adding alexei if he has any comments on the format so far

https://codereview.chromium.org/2769223005/diff/40001/tools/metrics/ukm/PRESU...
File tools/metrics/ukm/PRESUBMIT.py (right):

https://codereview.chromium.org/2769223005/diff/40001/tools/metrics/ukm/PRESU...
tools/metrics/ukm/PRESUBMIT.py:25: 'ukm.xml is not formatted correctly; run
%s/pretty_print.py '
since it's a const now I would use it here

https://codereview.chromium.org/2769223005/diff/40001/tools/metrics/ukm/model.py
File tools/metrics/ukm/model.py (right):

https://codereview.chromium.org/2769223005/diff/40001/tools/metrics/ukm/model...
tools/metrics/ukm/model.py:6: import logging
also unneeded import

[Steven Holte, 2017-04-04 18:20:51]

https://codereview.chromium.org/2769223005/diff/40001/tools/metrics/ukm/PRESU...
File tools/metrics/ukm/PRESUBMIT.py (right):

https://codereview.chromium.org/2769223005/diff/40001/tools/metrics/ukm/PRESU...
tools/metrics/ukm/PRESUBMIT.py:25: 'ukm.xml is not formatted correctly; run
%s/pretty_print.py '
On 2017/04/03 03:12:51, rkaplow (slow) wrote:
> since it's a const now I would use it here

Done.

https://codereview.chromium.org/2769223005/diff/40001/tools/metrics/ukm/model.py
File tools/metrics/ukm/model.py (right):

https://codereview.chromium.org/2769223005/diff/40001/tools/metrics/ukm/model...
tools/metrics/ukm/model.py:6: import logging
On 2017/04/03 03:12:51, rkaplow (slow) wrote:
> also unneeded import

Done.

[Steven Holte, 2017-04-04 18:21:33]

The CQ bit was checked by holte@chromium.org

[Steven Holte, 2017-04-04 18:21:33]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2769223005/#ps60001
(title: "Incorporate feedback")

[commit-bot: I haz the power, 2017-04-04 18:22:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-04-04 18:25:46]

Didn't look very closely, but generally lgtm on the format.

We can tweak it in the future.

https://codereview.chromium.org/2769223005/diff/60001/tools/metrics/ukm/prett...
File tools/metrics/ukm/pretty_print.py (right):

https://codereview.chromium.org/2769223005/diff/60001/tools/metrics/ukm/prett...
tools/metrics/ukm/pretty_print.py:13: 
Nit: too many blank lines?

[commit-bot: I haz the power, 2017-04-04 18:41:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491330093319090,
"parent_rev": "af04edf663f9e7e6806592134090eae43d703265", "commit_rev":
"deb93492c3c6ea9aaa2aecd6491dec38b4b722b0"}

[commit-bot: I haz the power, 2017-04-04 18:42:19]

Description was changed from

==========
Create a UKM descriptions XML file

BUG=678682
==========

to

==========
Create a UKM descriptions XML file

BUG=678682

Review-Url: https://codereview.chromium.org/2769223005
Cr-Commit-Position: refs/heads/master@{#461784}
Committed:
https://chromium.googlesource.com/chromium/src/+/deb93492c3c6ea9aaa2aecd6491d...
==========

[commit-bot: I haz the power, 2017-04-04 18:42:22]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/deb93492c3c6ea9aaa2aecd6491d...