Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: tools/metrics/ukm/PRESUBMIT.py

Issue 2769223005: Create a UKM descriptions XML file (Closed)
Patch Set: Update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 """Presubmit script for ukm.xml.
6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl.
9 """
10
11 UKM_XML = 'ukm.xml'
12
13
14 def CheckChange(input_api, output_api):
15 """Checks that ukm.xml is pretty-printed and well-formatted."""
16 for f in input_api.AffectedTextFiles():
17 p = f.AbsoluteLocalPath()
18 if (input_api.basename(p) == UKM_XML
19 and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()):
20 cwd = input_api.os_path.dirname(p)
21 exit_code = input_api.subprocess.call(
22 ['python', 'pretty_print.py', '--presubmit'], cwd=cwd)
23 if exit_code != 0:
24 return [output_api.PresubmitError(
25 'ukm.xml is not formatted correctly; run %s/pretty_print.py '
rkaplow 2017/04/03 03:12:51 since it's a const now I would use it here
Steven Holte 2017/04/04 18:20:51 Done.
26 'to fix' % input_api.PresubmitLocalPath())]
27 return []
28
29
30 def CheckChangeOnUpload(input_api, output_api):
31 return CheckChange(input_api, output_api)
32
33
34 def CheckChangeOnCommit(input_api, output_api):
35 return CheckChange(input_api, output_api)
OLDNEW
« no previous file with comments | « tools/metrics/ukm/OWNERS ('k') | tools/metrics/ukm/model.py » ('j') | tools/metrics/ukm/model.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698