Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: tools/metrics/ukm/PRESUBMIT.py

Issue 2769223005: Create a UKM descriptions XML file (Closed)
Patch Set: Add more metrics Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 """Presubmit script for ukm.xml.
6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl.
9 """
10
11
12 def CheckChange(input_api, output_api):
13 """Checks that ukm.xml is pretty-printed and well-formatted."""
14 for f in input_api.AffectedTextFiles():
15 p = f.AbsoluteLocalPath()
rkaplow 2017/03/30 01:26:20 optional, put ukm.xml as a const
Steven Holte 2017/03/30 22:42:23 Done.
16 if (input_api.basename(p) == 'ukm.xml'
17 and input_api.os_path.dirname(p) == input_api.PresubmitLocalPath()):
18 cwd = input_api.os_path.dirname(p)
19 exit_code = input_api.subprocess.call(
20 ['python', 'pretty_print.py', '--presubmit'], cwd=cwd)
21 if exit_code != 0:
22 return [output_api.PresubmitError(
23 'ukm.xml is not formatted correctly; run %s/pretty_print.py '
24 'to fix' % input_api.PresubmitLocalPath())]
25 return []
26
27
28 def CheckChangeOnUpload(input_api, output_api):
29 return CheckChange(input_api, output_api)
30
31
32 def CheckChangeOnCommit(input_api, output_api):
33 return CheckChange(input_api, output_api)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698