Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2769143002: [regexp] Rename result.group to result.groups (Closed)

Created:
3 years, 9 months ago by jgruber
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Rename result.group to result.groups This is just an update to reflect the current spec proposal. https://tc39.github.io/proposal-regexp-named-groups/ BUG=v8:5437 Review-Url: https://codereview.chromium.org/2769143002 Cr-Commit-Position: refs/heads/master@{#44067} Committed: https://chromium.googlesource.com/v8/v8/+/8c0f2315fcf1d3cb5f926c63e54d06adb7dba8fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/builtins/builtins-regexp-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-named-captures.js View 1 chunk +14 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 9 months ago (2017-03-23 10:42:09 UTC) #4
Yang
On 2017/03/23 10:42:09, jgruber wrote: lgtm.
3 years, 9 months ago (2017-03-23 14:59:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769143002/1
3 years, 9 months ago (2017-03-23 15:00:28 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 15:42:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8c0f2315fcf1d3cb5f926c63e54d06adb7d...

Powered by Google App Engine
This is Rietveld 408576698