Issue 2774613002: [regexp] Inline StringReplaceNonGlobalRegExpWithFunction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2774613002: [regexp] Inline StringReplaceNonGlobalRegExpWithFunction (Closed)

Created:
3 years, 9 months ago by jgruber

Modified:
3 years, 9 months ago

Reviewers:

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
v8

Visibility:
Public.

[regexp] Inline StringReplaceNonGlobalRegExpWithFunction BUG=v8:5437

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -90 lines)			Patch
	M	src/runtime/runtime-regexp.cc	View		2 chunks	+78 lines, -90 lines	0 comments	Download

Depends on Patchset:

Total messages: 2 (2 generated)

jgruber

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 10:53:33 UTC) #1

commit-bot: I haz the power

3 years, 9 months ago (2017-03-23 10:53:39 UTC) #2

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...