Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2766423004: [regexp] Inline StringReplaceNonGlobalRegExpWithFunction (Closed)

Created:
3 years, 9 months ago by jgruber
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Inline StringReplaceNonGlobalRegExpWithFunction BUG=v8:5437 Review-Url: https://codereview.chromium.org/2766423004 Cr-Commit-Position: refs/heads/master@{#44069} Committed: https://chromium.googlesource.com/v8/v8/+/6dcf074bb232eced60ff47fe225d3d32d4bf583e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -90 lines) Patch
M src/runtime/runtime-regexp.cc View 2 chunks +78 lines, -90 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
jgruber
No logic changes, just making an upcoming CL more readable.
3 years, 9 months ago (2017-03-23 10:55:07 UTC) #4
Yang
On 2017/03/23 10:55:07, jgruber wrote: > No logic changes, just making an upcoming CL more ...
3 years, 9 months ago (2017-03-23 12:26:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766423004/1
3 years, 9 months ago (2017-03-23 15:43:48 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 15:45:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6dcf074bb232eced60ff47fe225d3d32d4b...

Powered by Google App Engine
This is Rietveld 408576698