Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2769033004:
Should reset "Save-Data" header on all kinds of reloads (Closed)
|
Created:
3 years, 9 months ago by Takashi Toyoshima Modified:
3 years, 9 months ago CC:
chromium-reviews, blink-reviews, Yoav Weiss Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionShould reset "Save-Data" header on all kinds of reloads
Existing code just reset the "Save-Data" HTTP header only on
FrameLoadTypeReload. But this should be done for all kinds of reload
variants including ReloadMainResource and ReloadBypassingCache.
BUG=674404, 591594
Review-Url: https://codereview.chromium.org/2769033004
Cr-Commit-Position: refs/heads/master@{#459365}
Committed: https://chromium.googlesource.com/chromium/src/+/f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b
Patch Set 1 #Patch Set 2 : test #
Messages
Total messages: 24 (16 generated)
Description was changed from ========== Should clear "Save-Data" header on all kinds of reloads Existing code just clear the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG=674404 ========== to ========== Should clear "Save-Data" header on all kinds of reloads Existing code just clear the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG=674404 ==========
toyoshim@chromium.org changed reviewers: + japhet@chromium.org, rajendrant@chromium.org
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Should clear "Save-Data" header on all kinds of reloads Existing code just clear the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG=674404 ========== to ========== Should clear "Save-Data" header on all kinds of reloads Existing code just clear the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG=674404, 591594 ==========
Description was changed from ========== Should clear "Save-Data" header on all kinds of reloads Existing code just clear the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG=674404, 591594 ========== to ========== Should reset "Save-Data" header on all kinds of reloads Existing code just reset the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG=674404, 591594 ==========
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL. This code was originally added by Raj to fix an issue for reload. That change fixed the "on,on" issue, and added a functionality to reflect the current disabled/enabled setting on reload. But change for the latter did not work for hard reload.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/03/23 10:59:13, Takashi Toyoshima wrote: > PTAL. > > This code was originally added by Raj to fix an issue for reload. That change > fixed the "on,on" issue, and added a functionality to reflect the current > disabled/enabled setting on reload. But change for the latter did not work for > hard reload. lgtm
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
toyoshim@chromium.org changed reviewers: + kinuko@chromium.org
+kinuko for an approval.
lgtm
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490333049262480,
"parent_rev": "1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83", "commit_rev":
"f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b"}
Message was sent while issue was closed.
Description was changed from ========== Should reset "Save-Data" header on all kinds of reloads Existing code just reset the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG=674404, 591594 ========== to ========== Should reset "Save-Data" header on all kinds of reloads Existing code just reset the "Save-Data" HTTP header only on FrameLoadTypeReload. But this should be done for all kinds of reload variants including ReloadMainResource and ReloadBypassingCache. BUG=674404, 591594 Review-Url: https://codereview.chromium.org/2769033004 Cr-Commit-Position: refs/heads/master@{#459365} Committed: https://chromium.googlesource.com/chromium/src/+/f67faf0fa3c57d392fcf6b5d2b1c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f67faf0fa3c57d392fcf6b5d2b1c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
