Should reset "Save-Data" header on all kinds of reloads

third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

 /*
  * Copyright (c) 2015, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 678 matching lines @@
   // Low priority iframes enabled, everything should be low priority
   settings->setLowPriorityIframes(true);
   EXPECT_EQ(ResourceLoadPriorityVeryLow,
             childFetchContext->modifyPriorityForExperiments(
                 ResourceLoadPriorityVeryHigh));
   EXPECT_EQ(ResourceLoadPriorityVeryLow,
             childFetchContext->modifyPriorityForExperiments(
                 ResourceLoadPriorityMedium));
 }
 
+// Tests if "Save-Data" header is correctly added on the first load and reload.
 TEST_F(FrameFetchContextTest, EnableDataSaver) {
   Settings* settings = document->frame()->settings();
   settings->setDataSaverEnabled(true);
   ResourceRequest resourceRequest("http://www.example.com");
   fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
   EXPECT_EQ("on", resourceRequest.httpHeaderField("Save-Data"));
 
   // Subsequent call to addAdditionalRequestHeaders should not append to the
   // save-data header.
   fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
   EXPECT_EQ("on", resourceRequest.httpHeaderField("Save-Data"));
 }
 
+// Tests if "Save-Data" header is not added when the data saver is disabled.
 TEST_F(FrameFetchContextTest, DisabledDataSaver) {
   ResourceRequest resourceRequest("http://www.example.com");
   fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
   EXPECT_EQ(String(), resourceRequest.httpHeaderField("Save-Data"));
 }
 
+// Tests if reload variants can reflect the current data saver setting.
+TEST_F(FrameFetchContextTest, ChangeDataSaverConfig) {
+  Settings* settings = document->frame()->settings();
+  settings->setDataSaverEnabled(true);
+  ResourceRequest resourceRequest("http://www.example.com");
+  fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
+  EXPECT_EQ("on", resourceRequest.httpHeaderField("Save-Data"));
+
+  settings->setDataSaverEnabled(false);
+  document->loader()->setLoadType(FrameLoadTypeReloadMainResource);
+  fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
+  EXPECT_EQ(String(), resourceRequest.httpHeaderField("Save-Data"));
+
+  settings->setDataSaverEnabled(true);
+  fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
+  EXPECT_EQ("on", resourceRequest.httpHeaderField("Save-Data"));
+
+  settings->setDataSaverEnabled(false);
+  document->loader()->setLoadType(FrameLoadTypeReloadMainResource);
+  fetchContext->addAdditionalRequestHeaders(resourceRequest, FetchMainResource);
+  EXPECT_EQ(String(), resourceRequest.httpHeaderField("Save-Data"));
+}
+
 // Tests that the embedder gets correct notification when a resource is loaded
 // from the memory cache.
 TEST_F(FrameFetchContextMockedLocalFrameClientTest,
        DispatchDidLoadResourceFromMemoryCache) {
   ResourceRequest resourceRequest(url);
   Resource* resource = MockResource::create(resourceRequest);
   EXPECT_CALL(
       *client,
       dispatchDidLoadResourceFromMemoryCache(
           testing::AllOf(testing::Property(&ResourceRequest::url, url),
@@ skipping 178 matching lines @@
   setFilterPolicy(WebDocumentSubresourceFilter::WouldDisallow);
 
   EXPECT_EQ(ResourceRequestBlockedReason::None, canRequest());
   EXPECT_EQ(0, getFilteredLoadCallCount());
 
   EXPECT_EQ(ResourceRequestBlockedReason::None, canRequestPreload());
   EXPECT_EQ(0, getFilteredLoadCallCount());
 }
 
 }  // namespace blink