third_party/WebKit/Source/core/loader/FrameFetchContext.cpp - Issue 2769033004: Should reset "Save-Data" header on all kinds of reloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2769033004: Should reset "Save-Data" header on all kinds of reloads (Closed)

Patch Set: test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

index 5f8ca3e28039e6fc019e2d530e25f246699ca152..a220868732fec69b444aa1d15f19949d1cacc7db 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

@@ -375,7 +375,8 @@ void FrameFetchContext::addAdditionalRequestHeaders(ResourceRequest& request,

if (!request.url().isEmpty() && !request.url().protocolIsInHTTPFamily())

return;

- if (masterDocumentLoader()->loadType() == FrameLoadTypeReload)

+ // Reload should reflect the current data saver setting.

+ if (isReloadLoadType(masterDocumentLoader()->loadType()))

request.clearHTTPHeaderField("Save-Data");

if (frame()->settings() && frame()->settings()->getDataSaverEnabled())

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp » ('j') | no next file with comments »