[sql] WebSQL xGetLastError() can be called with null buffer.

[sql] WebSQL xGetLastError() can be called with null buffer.

Previously, xGetLastError() was never called, more recently it is
called.  os_win.c indicates that it can just make sure the buffer is
empty, but SQLite 3.17 calls it with a NULL pointer (and zero length) in
sqlite3OsGetLastError().

BUG=704009, 701518
Review-Url: https://codereview.chromium.org/2769033002
Cr-Commit-Position: refs/heads/master@{#459210}
Committed: https://chromium.googlesource.com/chromium/src/+/c9416cfaa6e0303da35d21214502be39239032a8

[Scott Hess - ex-Googler, 2017-03-22 23:38:41]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 23:39:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Scott Hess - ex-Googler, 2017-03-22 23:39:45]

shess@chromium.org changed reviewers:
+ michaeln@chromium.org

[Scott Hess - ex-Googler, 2017-03-22 23:39:46]

http://crbug.com/704009 is a null deref in this fn, which I traced to the fn
mentioned in the description.

As best I can determine, this information can only ever be used to create error
messages.  Since we previously did not populate it, I don't think it's possible
to detect this change in the websql client (other than the lack of crashing).

[commit-bot: I haz the power, 2017-03-23 01:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 01:25:12]

Dry run: This issue passed the CQ dry run.

[Scott Hess - ex-Googler, 2017-03-23 19:48:51]

Ping?

[michaeln, 2017-03-23 20:36:33]

https://codereview.chromium.org/2769033002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp
(right):

https://codereview.chromium.org/2769033002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp:331:
int chromiumGetLastError(sqlite3_vfs* vfs, int nBuf, char* zBuf) {
lgtm

[Scott Hess - ex-Googler, 2017-03-23 20:43:54]

The CQ bit was checked by shess@chromium.org

[Scott Hess - ex-Googler, 2017-03-23 20:44:01]

On 2017/03/23 20:36:33, michaeln wrote:
>
https://codereview.chromium.org/2769033002/diff/1/third_party/WebKit/Source/m...
> File
> third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp
> (right):
> 
>
https://codereview.chromium.org/2769033002/diff/1/third_party/WebKit/Source/m...
>
third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp:331:
> int chromiumGetLastError(sqlite3_vfs* vfs, int nBuf, char* zBuf) {
> lgtm

Thanks much!

[commit-bot: I haz the power, 2017-03-23 20:44:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:49:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490301834965390, "parent_rev":
"70cdc81ee387422102b362949621882df0bacd25", "commit_rev":
"c9416cfaa6e0303da35d21214502be39239032a8"}

[commit-bot: I haz the power, 2017-03-23 20:50:32]

Description was changed from

==========
[sql] WebSQL xGetLastError() can be called with null buffer.

Previously, xGetLastError() was never called, more recently it is
called.  os_win.c indicates that it can just make sure the buffer is
empty, but SQLite 3.17 calls it with a NULL pointer (and zero length) in
sqlite3OsGetLastError().

BUG=704009,701518
==========

to

==========
[sql] WebSQL xGetLastError() can be called with null buffer.

Previously, xGetLastError() was never called, more recently it is
called.  os_win.c indicates that it can just make sure the buffer is
empty, but SQLite 3.17 calls it with a NULL pointer (and zero length) in
sqlite3OsGetLastError().

BUG=704009,701518

Review-Url: https://codereview.chromium.org/2769033002
Cr-Commit-Position: refs/heads/master@{#459210}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9416cfaa6e0303da35d21214502...
==========

[commit-bot: I haz the power, 2017-03-23 20:50:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9416cfaa6e0303da35d21214502...