Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp

Issue 2769033002: [sql] WebSQL xGetLastError() can be called with null buffer. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp
index 21bacd7f5e0ff032227ba7d952e974a22fbea703..d59502eeeb646c9086f653f611a6f313eb27a64b 100644
--- a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp
@@ -328,10 +328,9 @@ int chromiumCurrentTime(sqlite3_vfs* vfs, double* prNow) {
return wrappedVfs->xCurrentTime(wrappedVfs, prNow);
}
-int chromiumGetLastError(sqlite3_vfs* vfs, int e, char* s) {
- // xGetLastError() has never been used by SQLite. The implementation in
- // os_win.c indicates this is a reasonable implementation.
- *s = '\0';
+int chromiumGetLastError(sqlite3_vfs* vfs, int nBuf, char* zBuf) {
michaeln 2017/03/23 20:36:33 lgtm
+ if (nBuf && zBuf)
+ *zBuf = '\0';
return 0;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698