third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp - Issue 2769033002: [sql] WebSQL xGetLastError() can be called with null buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp

Issue 2769033002: [sql] WebSQL xGetLastError() can be called with null buffer. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp ('K') | « third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp

index bc4fd2feadb8e6c1cdc040883656c933f22166a0..4e614bf0963abd7ebc1e990448af4eb053b4b9e6 100644

--- a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp

@@ -155,10 +155,9 @@ int chromiumCurrentTime(sqlite3_vfs* vfs, double* prNow) {

return wrappedVfs->xCurrentTime(wrappedVfs, prNow);

}

-int chromiumGetLastError(sqlite3_vfs* vfs, int e, char* s) {

- // xGetLastError() has never been used by SQLite. The implementation in

- // os_win.c indicates this is a reasonable implementation.

- *s = '\0';

+int chromiumGetLastError(sqlite3_vfs* vfs, int nBuf, char* zBuf) {

+ if (nBuf && zBuf)

+ *zBuf = '\0';

return 0;

}