Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2768933002: Reland of Add process uptime metadata event in tracing (Closed)

Created:
3 years, 9 months ago by ssid
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add process uptime metadata event in tracing (patchset #1 id:1 of https://codereview.chromium.org/2768123002/ ) Reason for revert: The race was caused by https://codereview.chromium.org/2736283003/ Fixed the post tasks. Original issue's description: > Revert of Add process uptime metadata event in tracing (patchset #4 id:80001 of https://codereview.chromium.org/2753133002/ ) > > Reason for revert: > Looks like this broke base_unittests on Linux TSan: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/2916 > > Original issue's description: > > Add process uptime metadata event in tracing > > > > 1. Make CurrentProcessInfo::CreationTime consistent on Linux with Win > > and Mac implementation: return null value instead of crashing on > > failure. > > 2. Use process_info_linux.cc in Android too, it works the same. > > 3. Add the total process uptime as meadata event in traces and > > whitelist in filtered mode. > > > > BUG=654667 > > > > Review-Url: https://codereview.chromium.org/2753133002 > > Cr-Commit-Position: refs/heads/master@{#458799} > > Committed: https://chromium.googlesource.com/chromium/src/+/a714d7dc0f1b8ecdee128db04e24b0da1087df8a > > TBR=oysteine@chromium.org,thakis@chromium.org,primiano@chromium.org,ssid@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=654667 > > Review-Url: https://codereview.chromium.org/2768123002 > Cr-Commit-Position: refs/heads/master@{#458869} > Committed: https://chromium.googlesource.com/chromium/src/+/958a4bb090a8f57113d094be99b573c036ecb1e0 TBR=oysteine@chromium.org,thakis@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=654667 Review-Url: https://codereview.chromium.org/2768933002 Cr-Commit-Position: refs/heads/master@{#459167} Committed: https://chromium.googlesource.com/chromium/src/+/dd8debd00f82d49bd0b0cf1a58c6a679540ee87a

Patch Set 1 : rebase original CL. #

Patch Set 2 : Fix if condition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M base/process/process_info_linux.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A base/process/process_info_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M base/trace_event/memory_dump_scheduler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_log.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/common/trace_event_args_whitelist.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
ssid
Created Reland of Add process uptime metadata event in tracing
3 years, 9 months ago (2017-03-22 21:01:34 UTC) #1
ssid
primiano, ptal. Thanks!
3 years, 9 months ago (2017-03-22 21:09:58 UTC) #5
Primiano Tucci (use gerrit)
LGTM given that the tests are coming in the other CL. thanks
3 years, 9 months ago (2017-03-23 15:53:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768933002/190001
3 years, 9 months ago (2017-03-23 15:54:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/390170)
3 years, 9 months ago (2017-03-23 17:39:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768933002/190001
3 years, 9 months ago (2017-03-23 18:01:20 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 19:07:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:190001) as
https://chromium.googlesource.com/chromium/src/+/dd8debd00f82d49bd0b0cf1a58c6...

Powered by Google App Engine
This is Rietveld 408576698