Add process uptime metadata event in tracing

Add process uptime metadata event in tracing

1. Make CurrentProcessInfo::CreationTime consistent on Linux with Win
   and Mac implementation: return null value instead of crashing on
   failure.
2. Use process_info_linux.cc in Android too, it works the same.
3. Add the total process uptime as meadata event in traces and
   whitelist in filtered mode.

BUG=654667
Review-Url: https://codereview.chromium.org/2753133002
Cr-Commit-Position: refs/heads/master@{#458799}
Committed: https://chromium.googlesource.com/chromium/src/+/a714d7dc0f1b8ecdee128db04e24b0da1087df8a

[ssid, 2017-03-16 23:23:35]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 23:24:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 23:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 23:33:52]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[ssid, 2017-03-21 00:08:39]

Description was changed from

==========
Add process runtime metadata event in tracing

Use process_info_linux.cc in Android, it works. Add the total process
runtime as meadata event in traces.

BUG=654667
==========

to

==========
Add process runtime metadata event in tracing

1. Make CurrentProcessInfo::CreationTime consistent on Linux with Win
   and Mac implementation: return null value instead of crashing on
   failure.
2. Use process_info_linux.cc in Android too, it works the same.
3. Add the total process runtime as meadata event in traces.

BUG=654667
==========

[ssid, 2017-03-21 00:10:33]

Patchset #2 (id:20001) has been deleted

[ssid, 2017-03-21 00:10:50]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 00:11:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ssid, 2017-03-21 01:04:25]

ssid@chromium.org changed reviewers:
+ oysteine@chromium.org, thakis@chromium.org

[ssid, 2017-03-21 01:04:25]

+thakis for base/ changes

+oysteine for tracing files

ptal thanks!

[oystein (OOO til 10th of July), 2017-03-21 17:21:06]

On 2017/03/21 at 01:04:25, ssid wrote:
> +thakis for base/ changes
> 
> +oysteine for tracing files
> 
> ptal thanks!

tracing lgtm

[Primiano Tucci (use gerrit), 2017-03-21 17:36:22]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2017-03-21 17:36:23]

one minor comment, although still lgtm from my viewpoint

https://codereview.chromium.org/2753133002/diff/60001/base/trace_event/trace_...
File base/trace_event/trace_log.cc (right):

https://codereview.chromium.org/2753133002/diff/60001/base/trace_event/trace_...
base/trace_event/trace_log.cc:1509: current_thread_id,
"process_runtime_seconds",
I'm the usual pain when it comes to naming, but I'd probably s/runtime/uptime/
call this process_uptime_seconds.
When I see runtime I never know whether that refers to "amount of cpu time" used
or "wall time".

[Nico, 2017-03-21 21:01:56]

base/ lgtm

https://codereview.chromium.org/2753133002/diff/60001/base/process/process_in...
File base/process/process_info_linux.cc (right):

https://codereview.chromium.org/2753133002/diff/60001/base/process/process_in...
base/process/process_info_linux.cc:20: if (!start_ticks)
this is covered by tests, yes?

[ssid, 2017-03-22 00:18:35]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 00:19:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ssid, 2017-03-22 00:41:09]

Thanks. Nico, ptal at unittest file.

https://codereview.chromium.org/2753133002/diff/60001/base/process/process_in...
File base/process/process_info_linux.cc (right):

https://codereview.chromium.org/2753133002/diff/60001/base/process/process_in...
base/process/process_info_linux.cc:20: if (!start_ticks)
On 2017/03/21 21:01:55, Nico wrote:
> this is covered by tests, yes?

I added an unittest.

https://codereview.chromium.org/2753133002/diff/60001/base/trace_event/trace_...
File base/trace_event/trace_log.cc (right):

https://codereview.chromium.org/2753133002/diff/60001/base/trace_event/trace_...
base/trace_event/trace_log.cc:1509: current_thread_id,
"process_runtime_seconds",
On 2017/03/21 17:36:22, Primiano Tucci wrote:
> I'm the usual pain when it comes to naming, but I'd probably s/runtime/uptime/
> call this process_uptime_seconds.
> When I see runtime I never know whether that refers to "amount of cpu time"
used
> or "wall time".

Done.

[commit-bot: I haz the power, 2017-03-22 01:29:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 01:29:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-03-22 01:33:24]

lgtm

[ssid, 2017-03-22 02:24:26]

The CQ bit was checked by ssid@chromium.org

[ssid, 2017-03-22 02:24:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, oysteine@chromium.org
Link to the patchset: https://codereview.chromium.org/2753133002/#ps80001
(title: "add unittest and rename to uptime.")

[ssid, 2017-03-22 02:25:13]

Description was changed from

==========
Add process runtime metadata event in tracing

1. Make CurrentProcessInfo::CreationTime consistent on Linux with Win
   and Mac implementation: return null value instead of crashing on
   failure.
2. Use process_info_linux.cc in Android too, it works the same.
3. Add the total process runtime as meadata event in traces.

BUG=654667
==========

to

==========
Add process uptime metadata event in tracing

1. Make CurrentProcessInfo::CreationTime consistent on Linux with Win
   and Mac implementation: return null value instead of crashing on
   failure.
2. Use process_info_linux.cc in Android too, it works the same.
3. Add the total process uptime as meadata event in traces and
   whitelist in filtered mode.

BUG=654667
==========

[commit-bot: I haz the power, 2017-03-22 02:25:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 04:27:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 04:27:03]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[ssid, 2017-03-22 05:09:14]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 05:09:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 05:14:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 05:14:10]

Dry run: This issue passed the CQ dry run.

[ssid, 2017-03-22 17:41:12]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 17:41:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 17:46:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 17:46:26]

Dry run: This issue passed the CQ dry run.

[ssid, 2017-03-22 17:55:24]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2017-03-22 17:56:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 18:06:15]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490205324420990,
"parent_rev": "affe6ebb8948d82592a7cf50e879eda526eabe81", "commit_rev":
"a714d7dc0f1b8ecdee128db04e24b0da1087df8a"}

[commit-bot: I haz the power, 2017-03-22 18:07:04]

Description was changed from

==========
Add process uptime metadata event in tracing

1. Make CurrentProcessInfo::CreationTime consistent on Linux with Win
   and Mac implementation: return null value instead of crashing on
   failure.
2. Use process_info_linux.cc in Android too, it works the same.
3. Add the total process uptime as meadata event in traces and
   whitelist in filtered mode.

BUG=654667
==========

to

==========
Add process uptime metadata event in tracing

1. Make CurrentProcessInfo::CreationTime consistent on Linux with Win
   and Mac implementation: return null value instead of crashing on
   failure.
2. Use process_info_linux.cc in Android too, it works the same.
3. Add the total process uptime as meadata event in traces and
   whitelist in filtered mode.

BUG=654667

Review-Url: https://codereview.chromium.org/2753133002
Cr-Commit-Position: refs/heads/master@{#458799}
Committed:
https://chromium.googlesource.com/chromium/src/+/a714d7dc0f1b8ecdee128db04e24...
==========

[commit-bot: I haz the power, 2017-03-22 18:07:05]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a714d7dc0f1b8ecdee128db04e24...

[dgozman, 2017-03-22 20:51:04]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/2768123002/ by dgozman@chromium.org.

The reason for reverting is: Looks like this broke base_unittests on Linux TSan:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%....

[ssid, 2017-03-22 21:04:29]

Patchset #5 (id:100001) has been deleted