Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2768123002: Revert of Add process uptime metadata event in tracing (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add process uptime metadata event in tracing (patchset #4 id:80001 of https://codereview.chromium.org/2753133002/ ) Reason for revert: Looks like this broke base_unittests on Linux TSan: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/2916 Original issue's description: > Add process uptime metadata event in tracing > > 1. Make CurrentProcessInfo::CreationTime consistent on Linux with Win > and Mac implementation: return null value instead of crashing on > failure. > 2. Use process_info_linux.cc in Android too, it works the same. > 3. Add the total process uptime as meadata event in traces and > whitelist in filtered mode. > > BUG=654667 > > Review-Url: https://codereview.chromium.org/2753133002 > Cr-Commit-Position: refs/heads/master@{#458799} > Committed: https://chromium.googlesource.com/chromium/src/+/a714d7dc0f1b8ecdee128db04e24b0da1087df8a TBR=oysteine@chromium.org,thakis@chromium.org,primiano@chromium.org,ssid@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654667 Review-Url: https://codereview.chromium.org/2768123002 Cr-Commit-Position: refs/heads/master@{#458869} Committed: https://chromium.googlesource.com/chromium/src/+/958a4bb090a8f57113d094be99b573c036ecb1e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -38 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M base/process/process_info_linux.cc View 1 chunk +2 lines, -4 lines 0 comments Download
D base/process/process_info_unittest.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M base/trace_event/trace_log.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/common/trace_event_args_whitelist.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dgozman
Created Revert of Add process uptime metadata event in tracing
3 years, 9 months ago (2017-03-22 20:51:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768123002/1
3 years, 9 months ago (2017-03-22 20:51:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/958a4bb090a8f57113d094be99b573c036ecb1e0
3 years, 9 months ago (2017-03-22 20:53:52 UTC) #6
ssid
3 years, 9 months ago (2017-03-22 21:01:34 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2768933002/ by ssid@chromium.org.

The reason for reverting is: The race was caused by
https://codereview.chromium.org/2736283003/
Fixed the post tasks..

Powered by Google App Engine
This is Rietveld 408576698