Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2768913005: Milo: Fix empty lines in step text (Closed)

Created:
3 years, 9 months ago by Ryan Tseng
Modified:
3 years, 9 months ago
Reviewers:
mithro, nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review and Tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -5 lines) Patch
M milo/api/proto/buildbot.pb.go View 1 1 chunk +1 line, -1 line 0 comments Download
M milo/api/proto/buildinfo.pb.go View 1 1 chunk +1 line, -1 line 0 comments Download
M milo/api/proto/pb.discovery.go View 1 1 chunk +1 line, -1 line 0 comments Download
A milo/appengine/buildbot/expectations/newline.1234.build.json View 1 1 chunk +66 lines, -0 lines 0 comments Download
M milo/appengine/buildbot/html_data.go View 1 1 chunk +1 line, -0 lines 0 comments Download
A milo/appengine/buildbot/testdata/newline.1234.json View 1 1 chunk +46 lines, -0 lines 0 comments Download
A milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html View 1 1 chunk +224 lines, -0 lines 0 comments Download
M milo/appengine/frontend/templates/pages/build.html View 1 1 chunk +5 lines, -1 line 0 comments Download
M milo/appengine/logdog/internal/stream.pb.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
hinoka
demo https://1621-6cb138d-tainted-hinoka-dot-luci-milo-dev.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/415680
3 years, 9 months ago (2017-03-24 18:36:29 UTC) #4
nodir
lgtm % test https://codereview.chromium.org/2768913005/diff/1/milo/appengine/frontend/templates/pages/build.html File milo/appengine/frontend/templates/pages/build.html (right): https://codereview.chromium.org/2768913005/diff/1/milo/appengine/frontend/templates/pages/build.html#newcode179 milo/appengine/frontend/templates/pages/build.html:179: </div>{{- end }} please put </div> ...
3 years, 9 months ago (2017-03-24 18:39:26 UTC) #5
hinoka
https://codereview.chromium.org/2768913005/diff/1/milo/appengine/frontend/templates/pages/build.html File milo/appengine/frontend/templates/pages/build.html (right): https://codereview.chromium.org/2768913005/diff/1/milo/appengine/frontend/templates/pages/build.html#newcode179 milo/appengine/frontend/templates/pages/build.html:179: </div>{{- end }} On 2017/03/24 18:39:26, nodir wrote: > ...
3 years, 9 months ago (2017-03-27 16:21:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768913005/20001
3 years, 9 months ago (2017-03-27 16:21:08 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 16:26:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/26d81493a96488be4ec8b6bc00fb3129de58eb15

Powered by Google App Engine
This is Rietveld 408576698