Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: milo/appengine/frontend/templates/pages/build.html

Issue 2768913005: Milo: Fix empty lines in step text (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {{define "title"}} 1 {{define "title"}}
2 {{ with .Build.Summary -}} 2 {{ with .Build.Summary -}}
3 {{ if eq .Status.String "InfraFailure" }} 3 {{ if eq .Status.String "InfraFailure" }}
4 Exception 4 Exception
5 {{ else if eq .Status.String "Failure" }} 5 {{ else if eq .Status.String "Failure" }}
6 Failed 6 Failed
7 {{ else if eq .Status.String "NotRun" }} 7 {{ else if eq .Status.String "NotRun" }}
8 Pending 8 Pending
9 {{ else }} 9 {{ else }}
10 {{ .Status.String }} 10 {{ .Status.String }}
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 {{ end }} 166 {{ end }}
167 167
168 {{ range .Build.Components }} 168 {{ range .Build.Components }}
169 <li class="verbosity-{{.Verbosity.String}}"> 169 <li class="verbosity-{{.Verbosity.String}}">
170 <div class="status-{{.Status}} result"> 170 <div class="status-{{.Status}} result">
171 <b>{{.Label}}</b> 171 <b>{{.Label}}</b>
172 {{ if .Duration -}} 172 {{ if .Duration -}}
173 <span style="float:right">( {{ .Duration | humanDuration }} )</s pan> 173 <span style="float:right">( {{ .Duration | humanDuration }} )</s pan>
174 {{- end }} 174 {{- end }}
175 <span> 175 <span>
176 {{ range .Text }}<div class="step-text">{{ . }}</div>{{ end }} 176 {{ range .Text -}}
177 <div class="step-text">
178 {{- if . -}}{{- . -}}{{- else -}}&nbsp;{{- end -}}
179 </div>{{- end }}
nodir 2017/03/24 18:39:26 please put </div> to the same indentation level as
hinoka 2017/03/27 16:21:01 Done.
177 </span> 180 </span>
178 </div> 181 </div>
179 <ul> 182 <ul>
180 {{ if .MainLink }} 183 {{ if .MainLink }}
181 <li>{{.MainLink | linkifySet}}</li> 184 <li>{{.MainLink | linkifySet}}</li>
182 {{- if eq .Verbosity.String "Interesting" -}} 185 {{- if eq .Verbosity.String "Interesting" -}}
183 {{ range .MainLink }} 186 {{ range .MainLink }}
184 <link rel="prerender" href="{{.URL}}"> 187 <link rel="prerender" href="{{.URL}}">
185 <link rel="prefetch" href="{{.URL}}"> 188 <link rel="prefetch" href="{{.URL}}">
186 {{ end }} 189 {{ end }}
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 } 295 }
293 }; 296 };
294 297
295 check($("#showHidden").is(":checked")); 298 check($("#showHidden").is(":checked"));
296 $("#showHidden").click(function(e) { 299 $("#showHidden").click(function(e) {
297 check($(this).is(":checked")); 300 check($(this).is(":checked"));
298 }); 301 });
299 }); 302 });
300 </script> 303 </script>
301 {{end}} 304 {{end}}
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698