Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(989)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: milo/appengine/buildbot/testdata/newline.1234.json
Issue
2768913005
:
Milo: Fix empty lines in step text (Closed)
Patch Set: Review and Tests
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
milo/api/proto/buildbot.pb.go
milo/api/proto/buildinfo.pb.go
milo/api/proto/pb.discovery.go
milo/appengine/buildbot/expectations/newline.1234.build.json
milo/appengine/buildbot/html_data.go
milo/appengine/buildbot/testdata/newline.1234.json
milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
milo/appengine/frontend/templates/pages/build.html
milo/appengine/logdog/internal/stream.pb.go
View unified diff
|
Download patch
« no previous file with comments
|
« milo/appengine/buildbot/html_data.go
('k') |
milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"sourcestamp": {
3
"changes": []
4
},
5
"results": 2,
6
"steps": [
7
{
8
"hidden": false,
9
"isFinished": true,
10
"isStarted": true,
11
"logs": [
12
[
13
"preamble",
14
"http://build.chromium.org/p/tryserver.chromium.win/builders /win_chromium_rel_ng/builds/246309/steps/steps/logs/preamble"
15
]
16
],
17
"name": "steps",
18
"results": [
19
2,
20
[
21
"steps"
22
]
23
],
24
"statistics": {},
25
"step_number": 0,
26
"text": [
27
"line 1<br><br>line 3"
28
],
29
"times": [
30
1467070230.081103,
31
1467071406.47502
32
],
33
"urls": {}
34
}
35
],
36
"text": [
37
"failed",
38
"steps",
39
"failed",
40
"compile (with patch)"
41
],
42
"times": [
43
1467070230.080228,
44
1467071406.476459
45
]
46
}
OLD
NEW
« no previous file with comments
|
« milo/appengine/buildbot/html_data.go
('k') |
milo/appengine/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html »
('j') |
no next file with comments »
Issue 2768913005: Milo: Fix empty lines in step text (Closed)
Created 3 years, 8 months ago by Ryan Tseng
Modified 3 years, 8 months ago
Reviewers: mithro, nodir, hinoka
Base URL:
Comments: 2
This is Rietveld
408576698
Chromium Code Reviews
Issue 2768913005:
Milo: Fix empty lines in step text (Closed)
