Change namespace from ui to gfx for NativePixmap related code

Change namespace from ui to gfx for NativePixmap related code

And change namespace from ui to gl for GLImageNativePixmap.

It should be have been included in these CLs:
https://codereview.chromium.org/2688623004/
https://codereview.chromium.org/2687093002/
https://codereview.chromium.org/2705333006/

R=sadrul@chromium.org, spang@chromium.org
TBR=ben@chromium.org, piman@chromium.org, reveman@chromium.org, sandersd@chromium.org
BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2768343002
Cr-Commit-Position: refs/heads/master@{#459551}
Committed: https://chromium.googlesource.com/chromium/src/+/f09c3132dafcb61d0ad6b682468c178dace960eb

[Julien Isorce, 2017-03-23 12:33:28]

Description was changed from

==========
Change namespace from ui to gfx for NativePixmap related code

And change namespace from ui to gl for GLImageNativePixmap.

It should be have been included in these CLs:
https://codereview.chromium.org/2688623004/
https://codereview.chromium.org/2687093002/
https://codereview.chromium.org/2705333006/

R=reveman@chromium.org, sadrul@chromium.org, spang@chromium.org
BUG=584248
==========

to

==========
Change namespace from ui to gfx for NativePixmap related code

And change namespace from ui to gl for GLImageNativePixmap.

It should be have been included in these CLs:
https://codereview.chromium.org/2688623004/
https://codereview.chromium.org/2687093002/
https://codereview.chromium.org/2705333006/

R=reveman@chromium.org, sadrul@chromium.org, spang@chromium.org
BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce, 2017-03-23 12:34:35]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 12:34:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 12:59:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 12:59:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Julien Isorce, 2017-03-23 13:12:26]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 13:12:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 15:04:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 15:04:20]

Dry run: This issue passed the CQ dry run.

[Julien Isorce, 2017-03-23 17:34:19]

On 2017/03/23 15:04:20, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Hi spang@, please take a look, espcially to
ui/ozone/generate_constructor_list.py . I removed a few namespace + ':: so that
was the downside but it still builds. Let me know. Thx.

[spang, 2017-03-23 17:38:22]

lgtm

[Julien Isorce, 2017-03-23 17:55:24]

On 2017/03/23 17:38:22, spang wrote:
> lgtm

Hi sadrul@, please have a look. Thx. Then for remaining files I will just do a
TBR I think.

[spang, 2017-03-23 17:58:51]

On 2017/03/23 17:34:19, Julien Isorce wrote:
> On 2017/03/23 15:04:20, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> Hi spang@, please take a look, espcially to
> ui/ozone/generate_constructor_list.py . I removed a few namespace + ':: so
that
> was the downside but it still builds. Let me know. Thx.

It's not a downside :) this is correct.

[sadrul, 2017-03-24 17:18:38]

lgtm

https://codereview.chromium.org/2768343002/diff/20001/ui/gfx/client_native_pi...
File ui/gfx/client_native_pixmap_factory.h (right):

https://codereview.chromium.org/2768343002/diff/20001/ui/gfx/client_native_pi...
ui/gfx/client_native_pixmap_factory.h:22: namespace gfx {
Merge with the block above.

[Julien Isorce, 2017-03-24 17:57:19]

Thx for the review.

https://codereview.chromium.org/2768343002/diff/20001/ui/gfx/client_native_pi...
File ui/gfx/client_native_pixmap_factory.h (right):

https://codereview.chromium.org/2768343002/diff/20001/ui/gfx/client_native_pi...
ui/gfx/client_native_pixmap_factory.h:22: namespace gfx {
On 2017/03/24 17:18:38, sadrul wrote:
> Merge with the block above.

Done.

[Julien Isorce, 2017-03-24 17:57:26]

The CQ bit was checked by julien.isorce@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 17:58:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:22:08]

Dry run: This issue passed the CQ dry run.

[Julien Isorce, 2017-03-24 20:26:07]

The CQ bit was checked by julien.isorce@chromium.org

[Julien Isorce, 2017-03-24 20:26:08]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
spang@chromium.org
Link to the patchset: https://codereview.chromium.org/2768343002/#ps40001
(title: "Addressed sadrul's remark")

[commit-bot: I haz the power, 2017-03-24 20:26:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:40:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Julien Isorce, 2017-03-24 20:52:30]

Description was changed from

==========
Change namespace from ui to gfx for NativePixmap related code

And change namespace from ui to gl for GLImageNativePixmap.

It should be have been included in these CLs:
https://codereview.chromium.org/2688623004/
https://codereview.chromium.org/2687093002/
https://codereview.chromium.org/2705333006/

R=reveman@chromium.org, sadrul@chromium.org, spang@chromium.org
BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change namespace from ui to gfx for NativePixmap related code

And change namespace from ui to gl for GLImageNativePixmap.

It should be have been included in these CLs:
https://codereview.chromium.org/2688623004/
https://codereview.chromium.org/2687093002/
https://codereview.chromium.org/2705333006/

R=sadrul@chromium.org, spang@chromium.org
TBR=ben@chromium.org, piman@chromium.org, reveman@chromium.org,
sandersd@chromium.org
BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce, 2017-03-24 20:52:45]

The CQ bit was checked by julien.isorce@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:53:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:06:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490388765202040,
"parent_rev": "6e3ba6453b8116dffe13e6ac317a22a7518b6962", "commit_rev":
"f09c3132dafcb61d0ad6b682468c178dace960eb"}

[commit-bot: I haz the power, 2017-03-24 21:07:03]

Description was changed from

==========
Change namespace from ui to gfx for NativePixmap related code

And change namespace from ui to gl for GLImageNativePixmap.

It should be have been included in these CLs:
https://codereview.chromium.org/2688623004/
https://codereview.chromium.org/2687093002/
https://codereview.chromium.org/2705333006/

R=sadrul@chromium.org, spang@chromium.org
TBR=ben@chromium.org, piman@chromium.org, reveman@chromium.org,
sandersd@chromium.org
BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change namespace from ui to gfx for NativePixmap related code

And change namespace from ui to gl for GLImageNativePixmap.

It should be have been included in these CLs:
https://codereview.chromium.org/2688623004/
https://codereview.chromium.org/2687093002/
https://codereview.chromium.org/2705333006/

R=sadrul@chromium.org, spang@chromium.org
TBR=ben@chromium.org, piman@chromium.org, reveman@chromium.org,
sandersd@chromium.org
BUG=584248
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2768343002
Cr-Commit-Position: refs/heads/master@{#459551}
Committed:
https://chromium.googlesource.com/chromium/src/+/f09c3132dafcb61d0ad6b682468c...
==========

[commit-bot: I haz the power, 2017-03-24 21:07:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f09c3132dafcb61d0ad6b682468c...