[InputEvent] Allow transpose and yank in plain-text field

[InputEvent] Allow transpose and yank in plain-text field

BUG=704036
Review-Url: https://codereview.chromium.org/2768303003
Cr-Commit-Position: refs/heads/master@{#459424}
Committed: https://chromium.googlesource.com/chromium/src/+/34e20090704e62dbb27e402b116e5a0259c385ee

[chongz, 2017-03-23 16:07:26]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 16:08:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 17:00:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:00:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chongz, 2017-03-23 23:15:59]

Description was changed from

==========
Allow transpose and yank in plain-text only field

BUG=704036
==========

to

==========
[InputEvent] Allow transpose and yank in plain-text field

BUG=704036
==========

[chongz, 2017-03-23 23:16:58]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2017-03-23 23:16:59]

yosin@ PTAL, thanks!

[yosin_UTC9, 2017-03-24 01:26:48]

lgtm

Please also see an issue[1], not urgent.


[1] http://crbug.com/704791 ⚐	"transpose" command should not change selection
when if it is canceled by beforeinput

https://codereview.chromium.org/2768303003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2768303003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:103:
case InputEvent::InputType::InsertFromYank:
BTW, Do we really need to have this switch-statement?
We have queryCommandEnabled(commandName) to do this.
Thus, we have two different places for checking command enablility.

[chongz, 2017-03-24 14:57:21]

> Please also see an issue[1], not urgent.
>
>
> [1] http://crbug.com/704791 ⚐	"transpose" command should not 
> change selection
> when if it is canceled by beforeinput

Will do.

https://codereview.chromium.org/2768303003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2768303003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:103:
case InputEvent::InputType::InsertFromYank:
On 2017/03/24 01:26:48, yosin_UTC9 wrote:
> BTW, Do we really need to have this switch-statement?
> We have queryCommandEnabled(commandName) to do this.
> Thus, we have two different places for checking command enablility.

This pattern was originated from WebKit, see:
https://chromium.googlesource.com/chromium/src/+blame/07a33c8ce604eeec637abe0...

But yes I think we can get rid of this as |queryCommandEnabled(commandName)| is
doing the same thing.

[chongz, 2017-03-24 14:57:30]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2017-03-24 14:58:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 15:04:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490367450094050, "parent_rev":
"fad633b5888c53d2cf46b6c4ec2eb7d196f7ad3f", "commit_rev":
"34e20090704e62dbb27e402b116e5a0259c385ee"}

[commit-bot: I haz the power, 2017-03-24 15:05:20]

Description was changed from

==========
[InputEvent] Allow transpose and yank in plain-text field

BUG=704036
==========

to

==========
[InputEvent] Allow transpose and yank in plain-text field

BUG=704036

Review-Url: https://codereview.chromium.org/2768303003
Cr-Commit-Position: refs/heads/master@{#459424}
Committed:
https://chromium.googlesource.com/chromium/src/+/34e20090704e62dbb27e402b116e...
==========

[commit-bot: I haz the power, 2017-03-24 15:05:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34e20090704e62dbb27e402b116e...