[InputEvent] Allow transpose and yank in plain-text field

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 82 matching lines @@
 
 bool CompositeEditCommand::apply() {
   DCHECK(!isCommandGroupWrapper());
   if (!endingSelection().isContentRichlyEditable()) {
     switch (inputType()) {
       case InputEvent::InputType::InsertText:
       case InputEvent::InputType::InsertLineBreak:
       case InputEvent::InputType::InsertParagraph:
       case InputEvent::InputType::InsertFromPaste:
       case InputEvent::InputType::InsertFromDrop:
+      case InputEvent::InputType::InsertFromYank:

[yosin_UTC9, 2017/03/24 01:26:48]

BTW, Do we really need to have this switch-statement?
We have queryCommandEnabled(commandName) to do this.
Thus, we have two different places for checking command enablility.

[chongz, 2017/03/24 14:57:20]

This pattern was originated from WebKit, see:
https://chromium.googlesource.com/chromium/src/+blame/07a33c8ce604eeec637abe0...

But yes I think we can get rid of this as |queryCommandEnabled(commandName)| is
doing the same thing.

+      case InputEvent::InputType::InsertTranspose:
       case InputEvent::InputType::InsertReplacementText:
       case InputEvent::InputType::InsertCompositionText:
       case InputEvent::InputType::DeleteWordBackward:
       case InputEvent::InputType::DeleteWordForward:
       case InputEvent::InputType::DeleteLineBackward:
       case InputEvent::InputType::DeleteLineForward:
       case InputEvent::InputType::DeleteContentBackward:
       case InputEvent::InputType::DeleteContentForward:
       case InputEvent::InputType::DeleteByCut:
       case InputEvent::InputType::DeleteByDrag:
       case InputEvent::InputType::None:
         break;
       default:
-        NOTREACHED();
+        NOTREACHED() << "Not supported input type on plain-text only element:"
+                     << static_cast<int>(inputType());
         return false;
     }
   }
   ensureUndoStep();
 
   // Changes to the document may have been made since the last editing operation
   // that require a layout, as in <rdar://problem/5658603>. Low level
   // operations, like RemoveNodeCommand, don't require a layout because the high
   // level operations that use them perform one if one is necessary (like for
   // the creation of VisiblePositions).
@@ skipping 1835 matching lines @@
 
 DEFINE_TRACE(CompositeEditCommand) {
   visitor->trace(m_commands);
   visitor->trace(m_startingSelection);
   visitor->trace(m_endingSelection);
   visitor->trace(m_undoStep);
   EditCommand::trace(visitor);
 }
 
 }  // namespace blink