Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2768303003: [InputEvent] Allow transpose and yank in plain-text field (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-yank.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
index 012a9693251f32f8d429ad6c62433ff70c5ff4e7..ec63558e4d4fb527ce51f90e25a72a682be932bc 100644
--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
@@ -100,6 +100,8 @@ bool CompositeEditCommand::apply() {
case InputEvent::InputType::InsertParagraph:
case InputEvent::InputType::InsertFromPaste:
case InputEvent::InputType::InsertFromDrop:
+ case InputEvent::InputType::InsertFromYank:
yosin_UTC9 2017/03/24 01:26:48 BTW, Do we really need to have this switch-stateme
chongz 2017/03/24 14:57:20 This pattern was originated from WebKit, see: http
+ case InputEvent::InputType::InsertTranspose:
case InputEvent::InputType::InsertReplacementText:
case InputEvent::InputType::InsertCompositionText:
case InputEvent::InputType::DeleteWordBackward:
@@ -113,7 +115,8 @@ bool CompositeEditCommand::apply() {
case InputEvent::InputType::None:
break;
default:
- NOTREACHED();
+ NOTREACHED() << "Not supported input type on plain-text only element:"
+ << static_cast<int>(inputType());
return false;
}
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-yank.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698