Chromium Code Reviews
Help | Chromium Project | Sign in
(6)

Issue 2768033002: Use size_t in crypto::SignatureVerifier. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by davidben
Modified:
1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use size_t in crypto::SignatureVerifier. Most places were already passing in a size_t and truncating. This should fix the remainig which I found. BUG=488553 Review-Url: https://codereview.chromium.org/2768033002 Cr-Commit-Position: refs/heads/master@{#459249} Committed: https://chromium.googlesource.com/chromium/src/+/cfb6ad6afbcbf21a718009d40895fbd7f33070ee

Patch Set 1 #

Patch Set 2 : rebas #

Patch Set 3 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
M components/client_update_protocol/ecdsa.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/crx_file/crx_file.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M crypto/signature_verifier.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M crypto/signature_verifier.cc View 1 2 5 chunks +13 lines, -11 lines 1 comment Download
M extensions/browser/content_verifier_delegate.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/verified_contents.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/verified_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/constants.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/constants.cc View 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 23 (16 generated)
davidben
eroman for //crypto sorin for client_update_protocol rockot for crx_file and extensions
1 month ago (2017-03-23 19:15:50 UTC) #14
davidben
https://codereview.chromium.org/2768033002/diff/40001/crypto/signature_verifier.cc File crypto/signature_verifier.cc (right): https://codereview.chromium.org/2768033002/diff/40001/crypto/signature_verifier.cc#newcode102 crypto/signature_verifier.cc:102: base::checked_cast<int>(salt_len)); This is an int because -1 and -2 ...
1 month ago (2017-03-23 19:16:57 UTC) #15
Sorin Jianu
lgtm Thank you! components/client_update_protocol/ecdsa.cc lgtm
1 month ago (2017-03-23 19:19:01 UTC) #16
Ken Rockot
lgtm
1 month ago (2017-03-23 19:20:12 UTC) #17
eroman
lgtm!
1 month ago (2017-03-23 22:02:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768033002/40001
1 month ago (2017-03-23 22:04:01 UTC) #20
commit-bot: I haz the power
1 month ago (2017-03-23 22:15:25 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cfb6ad6afbcbf21a718009d40895...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46