Use size_t in crypto::SignatureVerifier.

Use size_t in crypto::SignatureVerifier.

Most places were already passing in a size_t and truncating. This should
fix the remainig which I found.

BUG=488553
Review-Url: https://codereview.chromium.org/2768033002
Cr-Commit-Position: refs/heads/master@{#459249}
Committed: https://chromium.googlesource.com/chromium/src/+/cfb6ad6afbcbf21a718009d40895fbd7f33070ee

[davidben, 2017-03-22 19:13:31]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 19:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 19:17:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 19:17:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[davidben, 2017-03-22 22:41:03]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 22:41:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:47:27]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[davidben, 2017-03-23 14:59:19]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 14:59:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:19:05]

Dry run: This issue passed the CQ dry run.

[davidben, 2017-03-23 19:15:50]

davidben@chromium.org changed reviewers:
+ eroman@chromium.org, rockot@chromium.org, sorin@chromium.org

[davidben, 2017-03-23 19:15:50]

eroman for //crypto
sorin for client_update_protocol
rockot for crx_file and extensions

[davidben, 2017-03-23 19:16:57]

https://codereview.chromium.org/2768033002/diff/40001/crypto/signature_verifi...
File crypto/signature_verifier.cc (right):

https://codereview.chromium.org/2768033002/diff/40001/crypto/signature_verifi...
crypto/signature_verifier.cc:102: base::checked_cast<int>(salt_len));
This is an int because -1 and -2 are magic values for silly reasons. We probably
shouldn't export that via this API and it is otherwise measured in bytes, so I
kept it size_t at SignatureVerifier.

[Sorin Jianu, 2017-03-23 19:19:01]

lgtm

Thank you!

components/client_update_protocol/ecdsa.cc lgtm

[Ken Rockot(use gerrit already), 2017-03-23 19:20:12]

lgtm

[eroman, 2017-03-23 22:02:00]

lgtm!

[davidben, 2017-03-23 22:03:02]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:04:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:14:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490306582064780,
"parent_rev": "cead65052697a1c3ec0d2fbfb7ee0ee9a9e52963", "commit_rev":
"cfb6ad6afbcbf21a718009d40895fbd7f33070ee"}

[commit-bot: I haz the power, 2017-03-23 22:15:23]

Description was changed from

==========
Use size_t in crypto::SignatureVerifier.

Most places were already passing in a size_t and truncating. This should
fix the remainig which I found.

BUG=488553
==========

to

==========
Use size_t in crypto::SignatureVerifier.

Most places were already passing in a size_t and truncating. This should
fix the remainig which I found.

BUG=488553

Review-Url: https://codereview.chromium.org/2768033002
Cr-Commit-Position: refs/heads/master@{#459249}
Committed:
https://chromium.googlesource.com/chromium/src/+/cfb6ad6afbcbf21a718009d40895...
==========

[commit-bot: I haz the power, 2017-03-23 22:15:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cfb6ad6afbcbf21a718009d40895...