Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: components/crx_file/crx_file.cc

Issue 2768033002: Use size_t in crypto::SignatureVerifier. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crx_file/crx_file.cc
diff --git a/components/crx_file/crx_file.cc b/components/crx_file/crx_file.cc
index 2445ef1e6629bf5c439bfe0551acddde6d53ce60..c2b05f8e80b7467737a380f99d686e166a4e1ed0 100644
--- a/components/crx_file/crx_file.cc
+++ b/components/crx_file/crx_file.cc
@@ -160,8 +160,8 @@ CrxFile::ValidateError CrxFile::ValidateSignature(
crypto::SignatureVerifier verifier;
if (!verifier.VerifyInit(crypto::SignatureVerifier::RSA_PKCS1_SHA1,
- signature.data(), static_cast<int>(signature.size()),
- key.data(), static_cast<int>(key.size()))) {
+ signature.data(), signature.size(), key.data(),
+ key.size())) {
// Signature verification initialization failed. This is most likely
// caused by a public key in the wrong format (should encode algorithm).
return ValidateError::CRX_SIGNATURE_VERIFICATION_INITIALIZATION_FAILED;
@@ -170,7 +170,7 @@ CrxFile::ValidateError CrxFile::ValidateSignature(
uint8_t buf[1 << 12] = {};
while ((len = ReadAndHash(buf, sizeof(buf[0]), arraysize(buf), file.get(),
hash.get())) > 0)
- verifier.VerifyUpdate(buf, static_cast<int>(len));
+ verifier.VerifyUpdate(buf, len);
if (!verifier.VerifyFinal())
return ValidateError::CRX_SIGNATURE_VERIFICATION_FAILED;

Powered by Google App Engine
This is Rietveld 408576698