Implement fullNameForErrors on all Builders.

Implement fullNameForErrors on all Builders.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/c9d9b4d29567748599f4c4f4b2b2d3e797a9ba29

[ahe, 2017-03-21 18:05:24]

ahe@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-03-21 18:09:56]

https://codereview.chromium.org/2767653002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_variable_builder.dart (right):

https://codereview.chromium.org/2767653002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_variable_builder.dart:24: String get
fullNameForErrors => variable.name ?? "";
It seems like this might lead to user confusion.  How about something like:

String get fullNameForErrors => variable.name ?? "<unnamed>";

[ahe, 2017-03-21 18:22:18]

Thank you, Paul!

https://codereview.chromium.org/2767653002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_variable_builder.dart (right):

https://codereview.chromium.org/2767653002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_variable_builder.dart:24: String get
fullNameForErrors => variable.name ?? "";
On 2017/03/21 18:09:56, Paul Berry wrote:
> It seems like this might lead to user confusion.  How about something like:
> 
> String get fullNameForErrors => variable.name ?? "<unnamed>";

Yes. Will do.

[Paul Berry, 2017-03-21 18:25:57]

lgtm

[ahe, 2017-03-22 08:52:38]

Description was changed from

==========
Implement fullNameForErrors on all Builders.
==========

to

==========
Implement fullNameForErrors on all Builders.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c9d9b4d29567748599f4c4f4b2b2d3e797a9ba29
==========

[ahe, 2017-03-22 08:52:40]

Committed patchset #2 (id:20001) manually as
c9d9b4d29567748599f4c4f4b2b2d3e797a9ba29 (presubmit successful).