Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2768523002: Fix IdentifierContext for primary expressions. Also pass IdentifierContext to handleThisExpression … (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix IdentifierContext for primary expressions. Also pass IdentifierContext to handleThisExpression and handleSuperExpression. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/983a47293c2dbd7434dcd2ae1dd1880fd028c649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -37 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 6 chunks +6 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/identifier_context.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 10 chunks +16 lines, -15 lines 0 comments Download
M pkg/pkg.status View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
You already saw most of this in CL 2759173002.
3 years, 9 months ago (2017-03-21 15:20:19 UTC) #2
Paul Berry
lgtm
3 years, 9 months ago (2017-03-21 15:43:12 UTC) #3
ahe
3 years, 9 months ago (2017-03-22 08:39:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
983a47293c2dbd7434dcd2ae1dd1880fd028c649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698