Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: pkg/front_end/lib/src/fasta/builder/metadata_builder.dart

Issue 2767653002: Implement fullNameForErrors on all Builders. (Closed)
Patch Set: Used <unnamed> instead of empty string. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/metadata_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/metadata_builder.dart b/pkg/front_end/lib/src/fasta/builder/metadata_builder.dart
index 02f9f1038f0223f9353ab25022901302b18c98ce..f8ae45b4bd8269f1cbded3f92b5bc35f3be9d208 100644
--- a/pkg/front_end/lib/src/fasta/builder/metadata_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/metadata_builder.dart
@@ -37,6 +37,9 @@ class ConstructorMetadataBuilder<T extends TypeBuilder>
ConstructorMetadataBuilder(
this.constructorReference, this.arguments, Builder parent, int charOffset)
: super(parent, charOffset);
+
+ @override
+ String get fullNameForErrors => constructorReference.fullNameForErrors;
}
/// Expression metadata (without arguments).
@@ -53,4 +56,9 @@ class ExpressionMetadataBuilder<T extends TypeBuilder>
ExpressionMetadataBuilder(
this.qualified, this.identifier, Builder parent, int charOffset)
: super(parent, charOffset);
+
+ @override
+ String get fullNameForErrors {
+ return identifier == null ? qualified : "$qualified.$identifier";
+ }
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/member_builder.dart ('k') | pkg/front_end/lib/src/fasta/builder/mixed_accessor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698