Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: pkg/front_end/lib/src/fasta/builder/metadata_builder.dart

Issue 2767653002: Implement fullNameForErrors on all Builders. (Closed)
Patch Set: Used <unnamed> instead of empty string. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.metadata_builder; 5 library fasta.metadata_builder;
6 6
7 import 'builder.dart' show Builder, TypeBuilder; 7 import 'builder.dart' show Builder, TypeBuilder;
8 8
9 import 'constructor_reference_builder.dart' show ConstructorReferenceBuilder; 9 import 'constructor_reference_builder.dart' show ConstructorReferenceBuilder;
10 10
(...skipping 19 matching lines...) Expand all
30 30
31 class ConstructorMetadataBuilder<T extends TypeBuilder> 31 class ConstructorMetadataBuilder<T extends TypeBuilder>
32 extends MetadataBuilder<T> { 32 extends MetadataBuilder<T> {
33 final ConstructorReferenceBuilder constructorReference; 33 final ConstructorReferenceBuilder constructorReference;
34 34
35 final List arguments; 35 final List arguments;
36 36
37 ConstructorMetadataBuilder( 37 ConstructorMetadataBuilder(
38 this.constructorReference, this.arguments, Builder parent, int charOffset) 38 this.constructorReference, this.arguments, Builder parent, int charOffset)
39 : super(parent, charOffset); 39 : super(parent, charOffset);
40
41 @override
42 String get fullNameForErrors => constructorReference.fullNameForErrors;
40 } 43 }
41 44
42 /// Expression metadata (without arguments). 45 /// Expression metadata (without arguments).
43 /// 46 ///
44 /// Matches this grammar rule: 47 /// Matches this grammar rule:
45 /// 48 ///
46 /// '@' qualified (‘.’ identifier)? 49 /// '@' qualified (‘.’ identifier)?
47 class ExpressionMetadataBuilder<T extends TypeBuilder> 50 class ExpressionMetadataBuilder<T extends TypeBuilder>
48 extends MetadataBuilder<T> { 51 extends MetadataBuilder<T> {
49 final String qualified; 52 final String qualified;
50 53
51 final String identifier; 54 final String identifier;
52 55
53 ExpressionMetadataBuilder( 56 ExpressionMetadataBuilder(
54 this.qualified, this.identifier, Builder parent, int charOffset) 57 this.qualified, this.identifier, Builder parent, int charOffset)
55 : super(parent, charOffset); 58 : super(parent, charOffset);
59
60 @override
61 String get fullNameForErrors {
62 return identifier == null ? qualified : "$qualified.$identifier";
63 }
56 } 64 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/member_builder.dart ('k') | pkg/front_end/lib/src/fasta/builder/mixed_accessor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698