Sync SerializedScriptValue::wireFormatVersion with V8ScriptValueSerializer.

Sync SerializedScriptValue::wireFormatVersion with V8ScriptValueSerializer.

This updates the version seen by IndexedDB to match what
V8ScriptValueSerializer believes. This doesn't capture the V8-side versioning,
but is a step toward making things consistent.

BUG=704293
Review-Url: https://codereview.chromium.org/2767243002
Cr-Commit-Position: refs/heads/master@{#459118}
Committed: https://chromium.googlesource.com/chromium/src/+/6f58d02c2c69db09f474ac879795e6a97b5fa01f

[jbroman, 2017-03-22 21:41:27]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 21:42:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-03-22 21:45:35]

jbroman@chromium.org changed reviewers:
+ jsbell@chromium.org

[jbroman, 2017-03-22 21:45:36]

This is a step towards fixing the downgrade protection that I missed earlier. If
this is safe enough to merge into 58, it would at least make 58->57 profile
downgrades be handled more gracefully.

Ultimately, though, I think we'll need something more sophisticated because this
doesn't account for V8-side changes (except insofar as there may happen to be
Blink-side changes at a similar time).

[jsbell, 2017-03-22 21:50:09]

lgtm

[commit-bot: I haz the power, 2017-03-22 21:54:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:54:20]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbroman, 2017-03-22 22:09:15]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 22:09:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-03-22 22:10:20]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-03-22 22:10:21]

+haraken for remaining OWNERS

[haraken, 2017-03-22 23:41:32]

LGTM

[commit-bot: I haz the power, 2017-03-23 00:20:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:20:24]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-03-23 14:22:04]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-03-23 14:22:04]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/2767243002/#ps20001
(title: "fix spurious unused variable warning")

[commit-bot: I haz the power, 2017-03-23 14:22:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 14:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 14:26:15]

Failed to apply patch for
third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h:71
  error: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h:
patch does not apply

Patch:       third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
Index: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
index
2317349b8a006cfadb5d890e5af3578bdc8ee599..1fb9ce8668434b6933714799ad9d7755a468b795
100644
--- a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
+++ b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
@@ -71,7 +71,9 @@ class CORE_EXPORT SerializedScriptValue
   // Version 8: File.lastModified in milliseconds (seconds-based in earlier
   //            versions.)
   // Version 9: Added Map and Set support.
-  static const uint32_t wireFormatVersion = 9;
+  // [versions skipped]
+  // Version 16: Separate versioning between V8 and Blink.
+  static const uint32_t wireFormatVersion = 16;
 
   // VarInt encoding constants.
   static const int varIntShift = 7;

[jbroman, 2017-03-23 15:11:31]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-03-23 15:11:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/2767243002/#ps30006
(title: "Merge branch 'master' into ssv-version")

[commit-bot: I haz the power, 2017-03-23 15:11:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:44:34]

CQ is committing da patch.

Bot data: {"patchset_id": 30006, "attempt_start_ts": 1490281891779840,
"parent_rev": "3cbe9383775db9a30225c724f1c4b5d2447ce621", "commit_rev":
"6f58d02c2c69db09f474ac879795e6a97b5fa01f"}

[commit-bot: I haz the power, 2017-03-23 16:45:21]

Description was changed from

==========
Sync SerializedScriptValue::wireFormatVersion with V8ScriptValueSerializer.

This updates the version seen by IndexedDB to match what
V8ScriptValueSerializer believes. This doesn't capture the V8-side versioning,
but is a step toward making things consistent.

BUG=704293
==========

to

==========
Sync SerializedScriptValue::wireFormatVersion with V8ScriptValueSerializer.

This updates the version seen by IndexedDB to match what
V8ScriptValueSerializer believes. This doesn't capture the V8-side versioning,
but is a step toward making things consistent.

BUG=704293

Review-Url: https://codereview.chromium.org/2767243002
Cr-Commit-Position: refs/heads/master@{#459118}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f58d02c2c69db09f474ac879795...
==========

[commit-bot: I haz the power, 2017-03-23 16:45:22]

Committed patchset #3 (id:30006) as
https://chromium.googlesource.com/chromium/src/+/6f58d02c2c69db09f474ac879795...