Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp

Issue 2767243002: Sync SerializedScriptValue::wireFormatVersion with V8ScriptValueSerializer. (Closed)
Patch Set: Merge branch 'master' into ssv-version Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
index 5bfb83bff350d9776245bb18d52f7c1106b2847e..267a8ab5d524f53eef7a08b165e1bb09ee43be50 100644
--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
@@ -26,7 +26,8 @@
namespace blink {
// The "Blink-side" serialization version, which defines how Blink will behave
-// during the serialization process. The serialization format has two
+// during the serialization process, is in
+// SerializedScriptValue::wireFormatVersion. The serialization format has two
// "envelopes": an outer one controlled by Blink and an inner one by V8.
//
// They are formatted as follows:
@@ -40,7 +41,6 @@ namespace blink {
// This version number must be incremented whenever any incompatible changes are
// made to how Blink writes data. Purely V8-side changes do not require an
// adjustment to this value.
-static const uint32_t kLatestVersion = 16;
V8ScriptValueSerializer::V8ScriptValueSerializer(
RefPtr<ScriptState> scriptState,
@@ -68,7 +68,7 @@ RefPtr<SerializedScriptValue> V8ScriptValueSerializer::serialize(
// Write out the file header.
writeTag(VersionTag);
- writeUint32(kLatestVersion);
+ writeUint32(SerializedScriptValue::wireFormatVersion);
m_serializer.WriteHeader();
// Serialize the value and handle errors.

Powered by Google App Engine
This is Rietveld 408576698