Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: third_party/WebKit/Source/web/AssertMatchingEnums.cpp

Issue 2767243002: Sync SerializedScriptValue::wireFormatVersion with V8ScriptValueSerializer. (Closed)
Patch Set: Merge branch 'master' into ssv-version Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/AssertMatchingEnums.cpp
diff --git a/third_party/WebKit/Source/web/AssertMatchingEnums.cpp b/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
index 7adbc55241821c824fd3ed654201a3524cc4f830..32353003c3824d7798b9263823316d013c076a77 100644
--- a/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
+++ b/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
@@ -870,8 +870,12 @@ STATIC_ASSERT_ENUM(
WebSettings::ProgressBarCompletion::ResourcesBeforeDCLAndSameOriginIFrames,
ProgressBarCompletion::ResourcesBeforeDCLAndSameOriginIFrames);
+// This ensures that the version number published in
+// WebSerializedScriptValueVersion.h matches the serializer's understanding.
+// TODO(jbroman): Fix this to also account for the V8-side version. See
+// https://crbug.com/704293.
static_assert(kSerializedScriptValueVersion ==
SerializedScriptValue::wireFormatVersion,
- "");
+ "Update WebSerializedScriptValueVersion.h.");
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698