Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2672693002: Moved display property to be generated in ComputedStyleBase. (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 9 months ago
Reviewers:
sashab, Bugs Nash
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved display property to be generated in ComputedStyleBase. Move the noninherited property display and its enum, EDisplay, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. Note that this renames m_effectiveDisplay to m_display to match the name of the getter/setter. This shouldn't affect anything since the member is private and only used within the generated class. BUG=628043 Review-Url: https://codereview.chromium.org/2672693002 Cr-Commit-Position: refs/heads/master@{#459683} Committed: https://chromium.googlesource.com/chromium/src/+/4efed9fa047ba47f6f4849a597c49a741fafbd18

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Use generated mappings #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -175 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 1 chunk +0 lines, -134 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueIDMappings.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (15 generated)
shend
Hi Bugs, PTAL :)
3 years, 10 months ago (2017-02-02 04:27:13 UTC) #2
Bugs Nash
On 2017/02/02 at 04:27:13, shend wrote: > Hi Bugs, PTAL :) lgtm. Please add to ...
3 years, 10 months ago (2017-02-03 23:22:39 UTC) #3
shend
Thanks Bugs, done. Sasha, PTAL
3 years, 10 months ago (2017-02-06 00:09:33 UTC) #5
shend
Thanks Bugs, done. Sasha, PTAL
3 years, 10 months ago (2017-02-06 00:10:55 UTC) #7
sashab
LGTM. I wonder why its called m_effectiveDisplay. I guess originalDisplay is a non-property field?
3 years, 10 months ago (2017-02-07 03:00:42 UTC) #8
shend
On 2017/02/07 at 03:00:42, sashab wrote: > LGTM. I wonder why its called m_effectiveDisplay. I ...
3 years, 10 months ago (2017-02-07 03:12:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672693002/60001
3 years, 9 months ago (2017-03-27 00:08:03 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 00:14:02 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4efed9fa047ba47f6f4849a597c4...

Powered by Google App Engine
This is Rietveld 408576698