Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2766883002: Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). (Closed)

Created:
3 years, 9 months ago by hongchan
Modified:
3 years, 9 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). Currently Audit.loadFileFromUrl() checks the XHR status rigorously after its completion. This makes the XHR toward run-webkit-test server fail. To fix this issue, Audit.loadFileFromUrl() now accepts status = 0 in the |onload| handler. This change fixes the silent failure of XHR file fetching, thus enables some layout tests to do the actual buffer comparison within run-webkit-test. BUG=701813, 704021 TEST= LayoutTests/webaudio/unit-tests/audit.html LayoutTests/webaudio/unit-tests/audit-failures.html LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html Review-Url: https://codereview.chromium.org/2766883002 Cr-Original-Commit-Position: refs/heads/master@{#458621} Committed: https://chromium.googlesource.com/chromium/src/+/709962cdd9abacd997ca1a884bbccefbcb43c1ad Review-Url: https://codereview.chromium.org/2766883002 Cr-Commit-Position: refs/heads/master@{#458770} Committed: https://chromium.googlesource.com/chromium/src/+/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba

Patch Set 1 : Fix Audit.loadAudioFileFromUrl() #

Total comments: 7

Patch Set 2 : Adjust threshold for oscilator tests #

Total comments: 1

Patch Set 3 : Addressing feedback after l-g-t-m #

Patch Set 4 : Fixed threshold after revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -45 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 1 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js View 1 4 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html View 2 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 38 (29 generated)
hongchan
PTAL.
3 years, 9 months ago (2017-03-21 21:05:43 UTC) #4
Raymond Toy
lgtm with nits https://codereview.chromium.org/2766883002/diff/40001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2766883002/diff/40001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode1199 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:1199: // run-webkit-test has cross-domain file access ...
3 years, 9 months ago (2017-03-21 21:16:33 UTC) #5
hongchan
Please take one more look before landing. https://codereview.chromium.org/2766883002/diff/40001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2766883002/diff/40001/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode1199 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:1199: // run-webkit-test ...
3 years, 9 months ago (2017-03-21 23:07:58 UTC) #8
Raymond Toy
lgtm with nits. Be sure to update the description with the new changes and the ...
3 years, 9 months ago (2017-03-21 23:13:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766883002/80001
3 years, 9 months ago (2017-03-22 03:37:58 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/709962cdd9abacd997ca1a884bbccefbcb43c1ad
3 years, 9 months ago (2017-03-22 03:44:21 UTC) #25
horo
A revert of this CL (patchset #3 id:80001) has been created in https://codereview.chromium.org/2768773002/ by horo@chromium.org. ...
3 years, 9 months ago (2017-03-22 06:51:55 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766883002/100001
3 years, 9 months ago (2017-03-22 16:19:45 UTC) #35
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 16:27:24 UTC) #38
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a0e67dc1313e0e18fe5215ad75e4...

Powered by Google App Engine
This is Rietveld 408576698