Chromium Code Reviews
DescriptionAllow status = 0 when XHR is completed in Audit.loadFileFromUrl().
Currently Audit.loadFileFromUrl() checks the XHR status rigorously after
its completion. This makes the XHR toward run-webkit-test server fail.
To fix this issue, Audit.loadFileFromUrl() now accepts status = 0 in
the |onload| handler.
This change fixes the silent failure of XHR file fetching, thus enables
some layout tests to do the actual buffer comparison within
run-webkit-test.
BUG=701813, 704021
TEST=
LayoutTests/webaudio/unit-tests/audit.html
LayoutTests/webaudio/unit-tests/audit-failures.html
LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html
LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html
LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html
LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html
LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html
Review-Url: https://codereview.chromium.org/2766883002
Cr-Original-Commit-Position: refs/heads/master@{#458621}
Committed: https://chromium.googlesource.com/chromium/src/+/709962cdd9abacd997ca1a884bbccefbcb43c1ad
Review-Url: https://codereview.chromium.org/2766883002
Cr-Commit-Position: refs/heads/master@{#458770}
Committed: https://chromium.googlesource.com/chromium/src/+/a0e67dc1313e0e18fe5215ad75e4daa2bedf50ba
Patch Set 1 : Fix Audit.loadAudioFileFromUrl() #
Total comments: 7
Patch Set 2 : Adjust threshold for oscilator tests #
Total comments: 1
Patch Set 3 : Addressing feedback after l-g-t-m #Patch Set 4 : Fixed threshold after revert #Messages
Total messages: 38 (29 generated)
|