Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Issue 2766883002: Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). (Closed)
Patch Set: Fixed threshold after revert Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html
index 27bc852522a96e9162b0804ab017e3be08495d9d..adb2d78512b4572b6f5e65edb723036ad644cda2 100644
--- a/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html
+++ b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html
@@ -65,6 +65,20 @@
}
);
+ // Test Audit.loadFileFromUrl() within |should| assertion.
+ // See: crbug.com/701813
+ audit.define({
+ label: 'load-file-in-should',
+ description: 'Test Audit.loadFileFromUrl() within |should| assertion.'
+ }, (task, should) => {
+ let url = '../resources/hyper-reality/laughter.wav';
+ let promise = should(Audit.loadFileFromUrl(url),
+ 'Loading file within should().beResolved()')
+ .beResolved();
+ promise.then(() => { task.done() });
+ }
+ );
+
// The task headline needs to be printed even if there is no description is
// given.
@@ -89,7 +103,8 @@
// You can enumerate tasks you want to execute in the order, or simply pass
// no argument to run all the defined tasks.
- audit.run('numerical', 'basic', 'dummy-label-string', 'dummy-label-object');
+ audit.run('numerical', 'basic', 'load-file-in-should',
+ 'dummy-label-string', 'dummy-label-object');
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698