third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html - Issue 2766883002: Allow status = 0 when XHR is completed in Audit.loadFileFromUrl().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html

Issue 2766883002: Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). (Closed)

Patch Set: Fixed threshold after revert Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html ('k') | third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html

index 972822952b1bb072e64de80477c3cd6bf01ffc56..5d0366d6058e087e5e9d27e7ad4094b3ccf13c89 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html

@@ -19,12 +19,10 @@

let context = new OfflineAudioContext(1, tester.sampleRate *

tester.lengthInSeconds, tester.sampleRate);

- // Thresholds for verifying the test passes. The thresholds are

- // experimentally determined.

+ // The thresholds are experimentally determined.

tester.setThresholds({

- snr: 1000,

- maxDiff: 0,

- diffCount: 0

+ snr: 93.92,

+ maxDiff: 0.00005

});

tester.runTest(context, "triangle",

"Triangle Oscillator with Exponential Sweep ", task, should);