Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2766723003: Use unique pointers for U2fPacket and U2fMessage (Closed)

Created:
3 years, 9 months ago by Casey Piper
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use unique pointers for U2fPacket and U2fMessage U2fMessage and U2fPacket classes will have unique ownership so changing the classes to std::unique_ptr instead of shared_refptr. BUG=700594 Review-Url: https://codereview.chromium.org/2766723003 Cr-Commit-Position: refs/heads/master@{#458896} Committed: https://chromium.googlesource.com/chromium/src/+/a80b2b0045974cde9256cb838b5aeae10da1865e

Patch Set 1 #

Patch Set 2 : Rebase and use succinct base::Passed version #

Patch Set 3 : Change fuzzer to use the new unique_ptr constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -105 lines) Patch
M device/u2f/u2f_hid_device.h View 3 chunks +7 lines, -7 lines 0 comments Download
M device/u2f/u2f_hid_device.cc View 1 9 chunks +23 lines, -23 lines 0 comments Download
M device/u2f/u2f_message.h View 4 chunks +12 lines, -15 lines 0 comments Download
M device/u2f/u2f_message.cc View 6 chunks +22 lines, -19 lines 0 comments Download
M device/u2f/u2f_message_fuzzer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M device/u2f/u2f_message_unittest.cc View 9 chunks +19 lines, -18 lines 0 comments Download
M device/u2f/u2f_packet.h View 5 chunks +10 lines, -17 lines 0 comments Download
M device/u2f/u2f_packet.cc View 4 chunks +8 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Casey Piper
3 years, 9 months ago (2017-03-22 00:42:46 UTC) #3
Reilly Grant (use Gerrit)
lgtm however I suggest using base::Passed(&foo) instead of base::Passed(std::move(foo)).
3 years, 9 months ago (2017-03-22 02:56:50 UTC) #4
Casey Piper
On 2017/03/22 02:56:50, Reilly Grant wrote: > lgtm however I suggest using base::Passed(&foo) instead of ...
3 years, 9 months ago (2017-03-22 04:35:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766723003/40001
3 years, 9 months ago (2017-03-22 22:13:49 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 22:21:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a80b2b0045974cde9256cb838b5a...

Powered by Google App Engine
This is Rietveld 408576698