Use unique pointers for U2fPacket and U2fMessage

device/u2f/u2f_hid_device.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "u2f_hid_device.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "crypto/random.h"
@@ skipping 34 matching lines @@
       state_ = State::BUSY;
       Connect(base::Bind(&U2fHidDevice::OnConnect, weak_factory_.GetWeakPtr(),
                          base::Passed(&command), callback));
       break;
     case State::CONNECTED:
       state_ = State::BUSY;
       AllocateChannel(std::move(command), callback);
       break;
     case State::IDLE: {
       state_ = State::BUSY;
-      scoped_refptr<U2fMessage> msg = U2fMessage::Create(
+      std::unique_ptr<U2fMessage> msg = U2fMessage::Create(
           channel_id_, U2fMessage::Type::CMD_MSG, command->GetEncodedCommand());
-      WriteMessage(msg, true,
+      WriteMessage(std::move(msg), true,
                    base::Bind(&U2fHidDevice::MessageReceived,
                               weak_factory_.GetWeakPtr(), callback));
       break;
     }
     case State::BUSY:
       pending_transactions_.push_back({std::move(command), callback});
       break;
     case State::DEVICE_ERROR:
     default:
       base::WeakPtr<U2fHidDevice> self = weak_factory_.GetWeakPtr();
@@ skipping 25 matching lines @@
     state_ = State::DEVICE_ERROR;
   }
   Transition(std::move(command), callback);
 }
 
 void U2fHidDevice::AllocateChannel(std::unique_ptr<U2fApduCommand> command,
                                    const DeviceCallback& callback) {
   // Send random nonce to device to verify received message
   std::vector<uint8_t> nonce(8);
   crypto::RandBytes(nonce.data(), nonce.size());
-  scoped_refptr<U2fMessage> message =
+  std::unique_ptr<U2fMessage> message =
       U2fMessage::Create(channel_id_, U2fMessage::Type::CMD_INIT, nonce);
 
   WriteMessage(
-      message, true,
+      std::move(message), true,
       base::Bind(&U2fHidDevice::OnAllocateChannel, weak_factory_.GetWeakPtr(),
                  nonce, base::Passed(&command), callback));
 }
 
 void U2fHidDevice::OnAllocateChannel(std::vector<uint8_t> nonce,
                                      std::unique_ptr<U2fApduCommand> command,
                                      const DeviceCallback& callback,
                                      bool success,
-                                     scoped_refptr<U2fMessage> message) {
+                                     std::unique_ptr<U2fMessage> message) {
   if (!success || !message) {
     state_ = State::DEVICE_ERROR;
     Transition(nullptr, callback);
     return;
   }
   // Channel allocation response is defined as:
   // 0: 8 byte nonce
   // 8: 4 byte channel id
   // 12: Protocol version id
   // 13: Major device version
@@ skipping 19 matching lines @@
   channel_id_ = payload[index++] << 24;
   channel_id_ |= payload[index++] << 16;
   channel_id_ |= payload[index++] << 8;
   channel_id_ |= payload[index++];
   capabilities_ = payload[16];
 
   state_ = State::IDLE;
   Transition(std::move(command), callback);
 }
 
-void U2fHidDevice::WriteMessage(scoped_refptr<U2fMessage> message,
+void U2fHidDevice::WriteMessage(std::unique_ptr<U2fMessage> message,
                                 bool response_expected,
                                 U2fHidMessageCallback callback) {
   if (!connection_ || !message || message->NumPackets() == 0) {
     std::move(callback).Run(false, nullptr);
     return;
   }
 
   scoped_refptr<net::IOBufferWithSize> buffer = message->PopNextPacket();
 
   connection_->Write(
       buffer, buffer->size(),
       base::Bind(&U2fHidDevice::PacketWritten, weak_factory_.GetWeakPtr(),
-                 message, true, base::Passed(&callback)));
+                 base::Passed(&message), true, base::Passed(&callback)));
 }
 
-void U2fHidDevice::PacketWritten(scoped_refptr<U2fMessage> message,
+void U2fHidDevice::PacketWritten(std::unique_ptr<U2fMessage> message,
                                  bool response_expected,
                                  U2fHidMessageCallback callback,
                                  bool success) {
   if (success && message->NumPackets() > 0) {
-    WriteMessage(message, response_expected, std::move(callback));
+    WriteMessage(std::move(message), response_expected, std::move(callback));
   } else if (success && response_expected) {
     ReadMessage(std::move(callback));
   } else {
     std::move(callback).Run(success, nullptr);
   }
 }
 
 void U2fHidDevice::ReadMessage(U2fHidMessageCallback callback) {
   if (!connection_) {
     std::move(callback).Run(false, nullptr);
     return;
   }
 
   connection_->Read(base::Bind(&U2fHidDevice::OnRead,
                                weak_factory_.GetWeakPtr(),
                                base::Passed(&callback)));
 }
 
 void U2fHidDevice::OnRead(U2fHidMessageCallback callback,
                           bool success,
                           scoped_refptr<net::IOBuffer> buf,
                           size_t size) {
   if (!success) {
     std::move(callback).Run(success, nullptr);
     return;
   }
 
   scoped_refptr<net::IOBufferWithSize> buffer(new net::IOBufferWithSize(size));
   memcpy(buffer->data(), buf->data(), size);
-  scoped_refptr<U2fMessage> read_message =
+  std::unique_ptr<U2fMessage> read_message =
       U2fMessage::CreateFromSerializedData(buffer);
 
   if (!read_message) {
     std::move(callback).Run(false, nullptr);
     return;
   }
 
   // Received a message from a different channel, so try again
   if (channel_id_ != read_message->channel_id()) {
     connection_->Read(base::Bind(&U2fHidDevice::OnRead,
                                  weak_factory_.GetWeakPtr(),
                                  base::Passed(&callback)));
     return;
   }
 
   if (read_message->MessageComplete()) {
-    std::move(callback).Run(success, read_message);
+    std::move(callback).Run(success, std::move(read_message));
     return;
   }
 
   // Continue reading additional packets
-  connection_->Read(base::Bind(&U2fHidDevice::OnReadContinuation,
-                               weak_factory_.GetWeakPtr(), read_message,
-                               base::Passed(&callback)));
+  connection_->Read(
+      base::Bind(&U2fHidDevice::OnReadContinuation, weak_factory_.GetWeakPtr(),
+                 base::Passed(&read_message), base::Passed(&callback)));
 }
 
-void U2fHidDevice::OnReadContinuation(scoped_refptr<U2fMessage> message,
+void U2fHidDevice::OnReadContinuation(std::unique_ptr<U2fMessage> message,
                                       U2fHidMessageCallback callback,
                                       bool success,
                                       scoped_refptr<net::IOBuffer> buf,
                                       size_t size) {
   if (!success) {
     std::move(callback).Run(success, nullptr);
     return;
   }
 
   scoped_refptr<net::IOBufferWithSize> buffer(new net::IOBufferWithSize(size));
   memcpy(buffer->data(), buf->data(), size);
   message->AddContinuationPacket(buffer);
   if (message->MessageComplete()) {
-    std::move(callback).Run(success, message);
+    std::move(callback).Run(success, std::move(message));
     return;
   }
-  connection_->Read(base::Bind(&U2fHidDevice::OnReadContinuation,
-                               weak_factory_.GetWeakPtr(), message,
-                               base::Passed(&callback)));
+  connection_->Read(
+      base::Bind(&U2fHidDevice::OnReadContinuation, weak_factory_.GetWeakPtr(),
+                 base::Passed(&message), base::Passed(&callback)));
 }
 
 void U2fHidDevice::MessageReceived(const DeviceCallback& callback,
                                    bool success,
-                                   scoped_refptr<U2fMessage> message) {
+                                   std::unique_ptr<U2fMessage> message) {
   if (!success) {
     state_ = State::DEVICE_ERROR;
     Transition(nullptr, callback);
     return;
   }
   std::unique_ptr<U2fApduResponse> response = nullptr;
   if (message)
     response = U2fApduResponse::CreateFromMessage(message->GetMessagePayload());
   state_ = State::IDLE;
   base::WeakPtr<U2fHidDevice> self = weak_factory_.GetWeakPtr();
@@ skipping 10 matching lines @@
   }
 }
 
 void U2fHidDevice::TryWink(const WinkCallback& callback) {
   // Only try to wink if device claims support
   if (!(capabilities_ & kWinkCapability) || state_ != State::IDLE) {
     callback.Run();
     return;
   }
 
-  scoped_refptr<U2fMessage> wink_message = device::U2fMessage::Create(
+  std::unique_ptr<U2fMessage> wink_message = U2fMessage::Create(
       channel_id_, U2fMessage::Type::CMD_WINK, std::vector<uint8_t>());
   WriteMessage(
-      wink_message, true,
+      std::move(wink_message), true,
       base::Bind(&U2fHidDevice::OnWink, weak_factory_.GetWeakPtr(), callback));
 }
 
 void U2fHidDevice::OnWink(const WinkCallback& callback,
                           bool success,
-                          scoped_refptr<U2fMessage> response) {
+                          std::unique_ptr<U2fMessage> response) {
   callback.Run();
 }
 
 std::string U2fHidDevice::GetId() {
   std::ostringstream id("hid:");
   id << device_info_->device_id();
   return id.str();
 }
 
 // static
 bool U2fHidDevice::IsTestEnabled() {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   return command_line->HasSwitch(switches::kEnableU2fHidTest);
 }
 
 }  // namespace device