Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2743623006: Modify U2F apdu classes to use unique pointers (Closed)

Created:
3 years, 9 months ago by Casey Piper
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify U2F apdu classes to use unique pointers Apdu classes will have unique ownership, so changing the classes to std::unique_ptr instead of shared_refptr. BUG=700594 Review-Url: https://codereview.chromium.org/2743623006 Cr-Commit-Position: refs/heads/master@{#458774} Committed: https://chromium.googlesource.com/chromium/src/+/6de00828602a051db2bb66c17e5867b5559d2ef3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and update, fix nits #

Total comments: 2

Patch Set 3 : Use more concise form of base::Passed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -113 lines) Patch
M device/u2f/u2f_apdu_command.h View 1 4 chunks +18 lines, -21 lines 0 comments Download
M device/u2f/u2f_apdu_command.cc View 1 7 chunks +13 lines, -16 lines 0 comments Download
M device/u2f/u2f_apdu_fuzzer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M device/u2f/u2f_apdu_response.h View 3 chunks +6 lines, -6 lines 0 comments Download
M device/u2f/u2f_apdu_response.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M device/u2f/u2f_apdu_unittest.cc View 1 11 chunks +11 lines, -10 lines 0 comments Download
M device/u2f/u2f_device.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M device/u2f/u2f_device.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M device/u2f/u2f_hid_device.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M device/u2f/u2f_hid_device.cc View 1 2 11 chunks +20 lines, -20 lines 0 comments Download
M device/u2f/u2f_hid_device_unittest.cc View 1 5 chunks +16 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 35 (29 generated)
Reilly Grant (use Gerrit)
lgtm with nits about using base::MakeUnique any time you have: std::unique_ptr<Foo> foo(new Foo(...)); https://codereview.chromium.org/2743623006/diff/1/device/u2f/u2f_apdu_command.cc File ...
3 years, 9 months ago (2017-03-20 17:44:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743623006/60001
3 years, 9 months ago (2017-03-21 22:59:06 UTC) #21
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2743623006/diff/60001/device/u2f/u2f_hid_device.cc File device/u2f/u2f_hid_device.cc (right): https://codereview.chromium.org/2743623006/diff/60001/device/u2f/u2f_hid_device.cc#newcode47 device/u2f/u2f_hid_device.cc:47: base::Passed(std::move(command)), callback)); base::Passed(std::move(foo)) is fine but you can use ...
3 years, 9 months ago (2017-03-21 23:02:29 UTC) #22
Casey Piper
https://codereview.chromium.org/2743623006/diff/60001/device/u2f/u2f_hid_device.cc File device/u2f/u2f_hid_device.cc (right): https://codereview.chromium.org/2743623006/diff/60001/device/u2f/u2f_hid_device.cc#newcode47 device/u2f/u2f_hid_device.cc:47: base::Passed(std::move(command)), callback)); On 2017/03/21 23:02:29, Reilly Grant wrote: > ...
3 years, 9 months ago (2017-03-21 23:26:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743623006/80001
3 years, 9 months ago (2017-03-22 16:31:24 UTC) #32
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 16:38:22 UTC) #35
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6de00828602a051db2bb66c17e58...

Powered by Google App Engine
This is Rietveld 408576698