[regexp] Named capture support for callable replacements

[regexp] Named capture support for callable replacements

This implements support for named captures in
RegExp.prototype[@@replace] for when the replaceValue is callable.

In that case, the result.groups object is passed to the replacer
function as the last argument.

BUG=v8:5437
Review-Url: https://codereview.chromium.org/2764343004
Cr-Commit-Position: refs/heads/master@{#44142}
Committed: https://chromium.googlesource.com/v8/v8/+/80879b8c26818913f03cb5ec413e764fc39b498e

[jgruber, 2017-03-23 10:57:43]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 10:57:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-23 11:36:16]

jgruber@chromium.org changed reviewers:
+ littledan@chromium.org, yangguo@chromium.org

[commit-bot: I haz the power, 2017-03-23 11:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 11:38:27]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-23 14:58:22]

LGTM. Awesome.

https://codereview.chromium.org/2764343004/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2764343004/diff/1/src/objects.cc#newcode6576
src/objects.cc:6576: Maybe<bool>
JSReceiver::CreateDataProperty(Handle<JSReceiver> holder,
Does JSObject::AddProperty not fit the purpose? We know that we are dealing with
a new object with null proto after all.

https://codereview.chromium.org/2764343004/diff/1/test/mjsunit/harmony/regexp...
File test/mjsunit/harmony/regexp-named-captures.js (right):

https://codereview.chromium.org/2764343004/diff/1/test/mjsunit/harmony/regexp...
test/mjsunit/harmony/regexp-named-captures.js:210: }
Not directly related to this CL. Could we have some tests for interactions with

- lookbehind assertions
- nested groups
- number for group names

[jgruber, 2017-03-24 14:06:46]

https://codereview.chromium.org/2764343004/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2764343004/diff/1/src/objects.cc#newcode6576
src/objects.cc:6576: Maybe<bool>
JSReceiver::CreateDataProperty(Handle<JSReceiver> holder,
On 2017/03/23 14:58:22, Yang wrote:
> Does JSObject::AddProperty not fit the purpose? We know that we are dealing
with
> a new object with null proto after all.

Good point, CreateDataProperty ends up calling that anyways.

https://codereview.chromium.org/2764343004/diff/1/src/runtime/runtime-regexp.cc
File src/runtime/runtime-regexp.cc (right):

https://codereview.chromium.org/2764343004/diff/1/src/runtime/runtime-regexp....
src/runtime/runtime-regexp.cc:1047: // named captures, they are also passed just
before the index.
The proposal just changed, groups are now passed as the last argument. I'll
update the implementation in a follow-up.

https://codereview.chromium.org/2764343004/diff/1/test/mjsunit/harmony/regexp...
File test/mjsunit/harmony/regexp-named-captures.js (right):

https://codereview.chromium.org/2764343004/diff/1/test/mjsunit/harmony/regexp...
test/mjsunit/harmony/regexp-named-captures.js:210: }
On 2017/03/23 14:58:22, Yang wrote:
> Not directly related to this CL. Could we have some tests for interactions
with
> 
> - lookbehind assertions
> - nested groups
> - number for group names

Acknowledged.

[jgruber, 2017-03-27 10:16:06]

Description was changed from

==========
[regexp] Named capture support for callable replacements

This implements support for named captures in
RegExp.prototype[@@replace] for when the replaceValue is callable.

In that case, the result.groups object is passed to the replacer
function as the third-to-last argument.

BUG=v8:5437
==========

to

==========
[regexp] Named capture support for callable replacements

This implements support for named captures in
RegExp.prototype[@@replace] for when the replaceValue is callable.

In that case, the result.groups object is passed to the replacer
function as the last argument.

BUG=v8:5437
==========

[jgruber, 2017-03-27 10:16:52]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 10:17:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 10:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 10:42:07]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-03-27 10:51:40]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-03-27 10:51:41]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2764343004/#ps40001
(title: "Final tweaks")

[commit-bot: I haz the power, 2017-03-27 10:51:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 11:18:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490611900860590,
"parent_rev": "980448dfcd304960d12a3f4c593775727d5a317d", "commit_rev":
"80879b8c26818913f03cb5ec413e764fc39b498e"}

[commit-bot: I haz the power, 2017-03-27 11:18:37]

Description was changed from

==========
[regexp] Named capture support for callable replacements

This implements support for named captures in
RegExp.prototype[@@replace] for when the replaceValue is callable.

In that case, the result.groups object is passed to the replacer
function as the last argument.

BUG=v8:5437
==========

to

==========
[regexp] Named capture support for callable replacements

This implements support for named captures in
RegExp.prototype[@@replace] for when the replaceValue is callable.

In that case, the result.groups object is passed to the replacer
function as the last argument.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2764343004
Cr-Commit-Position: refs/heads/master@{#44142}
Committed:
https://chromium.googlesource.com/v8/v8/+/80879b8c26818913f03cb5ec413e764fc39...
==========

[commit-bot: I haz the power, 2017-03-27 11:18:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/80879b8c26818913f03cb5ec413e764fc39...