Reland of "[memory-infra] Add unittests for peak detection and NotifyDumpTriggered"

Revert of Revert "[memory-infra] Add unittests for peak detection and NotifyDumpTriggered" (patchset #1 id:1 of https://codereview.chromium.org/2766933004/ )

Reason for revert:
Reland with extra asserts to debug the failure in waterfall.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed: https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f8103b82febb1

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
BUG=607533
Review-Url: https://codereview.chromium.org/2766303002
Cr-Commit-Position: refs/heads/master@{#458953}
Committed: https://chromium.googlesource.com/chromium/src/+/82b21b9b3985d1795b8198e52580ee188b89bebc

[ssid, 2017-03-22 17:37:43]

Created Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"

[ssid, 2017-03-22 17:40:40]

Description was changed from

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Trying to reland.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607533
==========

to

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Trying to reland.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607533
==========

[Primiano Tucci (use gerrit), 2017-03-22 17:50:10]

Make sure you remove the NOTRY & co.
Also I guess that something needs to change in order to not re-break the CFI bot
:)

[ssid, 2017-03-22 17:53:01]

On 2017/03/22 17:50:10, Primiano Tucci wrote:
> Make sure you remove the NOTRY & co.
> Also I guess that something needs to change in order to not re-break the CFI
bot
> :)

Yes I am trying to run the CFI bot. added NOT FOR REVIEW in the CL.

[ssid, 2017-03-22 17:53:29]

Description was changed from

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Trying to reland.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607533
==========

to

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Trying to reland.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=dcheng@chromium.org,krasin@chromium.org
BUG=607533
==========

[krasin1, 2017-03-22 19:10:17]

On 2017/03/22 17:53:01, ssid wrote:
> On 2017/03/22 17:50:10, Primiano Tucci wrote:
> > Make sure you remove the NOTRY & co.
> > Also I guess that something needs to change in order to not re-break the CFI
> bot
> > :)
> 
> Yes I am trying to run the CFI bot. added NOT FOR REVIEW in the CL.

Another (very similar) trybot run just succeeded:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
So, the issue is only reproducible on the build bots, but not trybots and not
workstations.

This is very weird, and I will deal with that later.

[ssid, 2017-03-22 20:58:36]

Description was changed from

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Trying to reland.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=dcheng@chromium.org,krasin@chromium.org
BUG=607533
==========

to

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Trying to reland.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
BUG=607533
==========

[ssid, 2017-03-22 20:59:08]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 21:00:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 22:09:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:09:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ssid, 2017-03-22 23:48:08]

On 2017/03/22 19:10:17, krasin1 wrote:
> On 2017/03/22 17:53:01, ssid wrote:
> > On 2017/03/22 17:50:10, Primiano Tucci wrote:
> > > Make sure you remove the NOTRY & co.
> > > Also I guess that something needs to change in order to not re-break the
CFI
> > bot
> > > :)
> > 
> > Yes I am trying to run the CFI bot. added NOT FOR REVIEW in the CL.
> 
> Another (very similar) trybot run just succeeded:
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
> So, the issue is only reproducible on the build bots, but not trybots and not
> workstations.
> 
> This is very weird, and I will deal with that later.

Okay I am committing this with few extra asserts to debug the failure in the
waterfall, since it's not possible to reproduce the issue otherwise.

[ssid, 2017-03-22 23:48:45]

Description was changed from

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Trying to reland.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
BUG=607533
==========

to

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Reland with extra asserts to debug the failure in waterfall.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
BUG=607533
==========

[ssid, 2017-03-22 23:48:58]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:49:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:30:08]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490226538477400,
"parent_rev": "cf76073aac63d2e460740d7562ee1523e6a0c7d8", "commit_rev":
"82b21b9b3985d1795b8198e52580ee188b89bebc"}

[commit-bot: I haz the power, 2017-03-23 00:30:52]

Description was changed from

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Reland with extra asserts to debug the failure in waterfall.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
BUG=607533
==========

to

==========
Revert of Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered" (patchset #1 id:1 of
https://codereview.chromium.org/2766933004/ )

Reason for revert:
Reland with extra asserts to debug the failure in waterfall.

Original issue's description:
> Revert "[memory-infra] Add unittests for peak detection and
NotifyDumpTriggered"
> 
> Reason: breaks CFI buildbots
> 
> https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852
> 
> This reverts the CL https://codereview.chromium.org/2743663005
> 
> BUG=607533
> TBR=dcheng
> 
> Review-Url: https://codereview.chromium.org/2766933004
> Cr-Commit-Position: refs/heads/master@{#458787}
> Committed:
https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f...

TBR=primiano@chromium.org,dcheng@chromium.org,krasin@chromium.org
BUG=607533

Review-Url: https://codereview.chromium.org/2766303002
Cr-Commit-Position: refs/heads/master@{#458953}
Committed:
https://chromium.googlesource.com/chromium/src/+/82b21b9b3985d1795b8198e52580...
==========

[commit-bot: I haz the power, 2017-03-23 00:30:53]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/82b21b9b3985d1795b8198e52580...