Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2766933004: Revert "[memory-infra] Add unittests for peak detection and NotifyDumpTriggered" (Closed)

Created:
3 years, 9 months ago by krasin1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[memory-infra] Add unittests for peak detection and NotifyDumpTriggered" Reason: breaks CFI buildbots https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/7700 https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5852 This reverts the CL https://codereview.chromium.org/2743663005 BUG=607533 TBR=dcheng Review-Url: https://codereview.chromium.org/2766933004 Cr-Commit-Position: refs/heads/master@{#458787} Committed: https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f8103b82febb1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -99 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/memory_dump_scheduler.h View 2 chunks +2 lines, -3 lines 0 comments Download
D base/trace_event/memory_dump_scheduler_unittest.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
krasin1
3 years, 9 months ago (2017-03-22 16:05:23 UTC) #4
Primiano Tucci (use gerrit)
lgtm
3 years, 9 months ago (2017-03-22 16:19:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766933004/1
3 years, 9 months ago (2017-03-22 16:28:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/391657)
3 years, 9 months ago (2017-03-22 16:36:23 UTC) #10
krasin1
3 years, 9 months ago (2017-03-22 16:43:53 UTC) #12
Primiano Tucci (use gerrit)
On 2017/03/22 16:43:53, krasin1 wrote: You need a TBR for base/build.gn
3 years, 9 months ago (2017-03-22 16:45:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766933004/1
3 years, 9 months ago (2017-03-22 16:54:31 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/68d51c6dd7715dcb357341845d7f8103b82febb1
3 years, 9 months ago (2017-03-22 17:14:27 UTC) #20
ssid
3 years, 9 months ago (2017-03-22 17:37:42 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2766303002/ by ssid@chromium.org.

The reason for reverting is: Trying to reland..

Powered by Google App Engine
This is Rietveld 408576698