Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2522)

Unified Diff: base/trace_event/memory_dump_scheduler.h

Issue 2766303002: Reland of "[memory-infra] Add unittests for peak detection and NotifyDumpTriggered" (Closed)
Patch Set: Add more asserts. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/trace_event/memory_dump_scheduler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_scheduler.h
diff --git a/base/trace_event/memory_dump_scheduler.h b/base/trace_event/memory_dump_scheduler.h
index fd21fce834949be99aa386a1e12362a103368d48..4cf0fd0b1585091fb56d11a44f52e17a488e6a47 100644
--- a/base/trace_event/memory_dump_scheduler.h
+++ b/base/trace_event/memory_dump_scheduler.h
@@ -50,10 +50,12 @@ class BASE_EXPORT MemoryDumpScheduler {
private:
friend class MemoryDumpManagerTest;
+ friend class MemoryDumpSchedulerPollingTest;
FRIEND_TEST_ALL_PREFIXES(MemoryDumpManagerTest, TestPollingOnDumpThread);
+ FRIEND_TEST_ALL_PREFIXES(MemoryDumpSchedulerPollingTest, NotifyDumpTriggered);
// Helper class to schdule periodic memory dumps.
- struct PeriodicTriggerState {
+ struct BASE_EXPORT PeriodicTriggerState {
PeriodicTriggerState();
~PeriodicTriggerState();
@@ -71,7 +73,7 @@ class BASE_EXPORT MemoryDumpScheduler {
DISALLOW_COPY_AND_ASSIGN(PeriodicTriggerState);
};
- struct PollingTriggerState {
+ struct BASE_EXPORT PollingTriggerState {
enum State {
CONFIGURED, // Polling trigger was added.
ENABLED, // Polling is running.
« no previous file with comments | « base/BUILD.gn ('k') | base/trace_event/memory_dump_scheduler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698