Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 2765683003: Reland of Ignore pointer capture target while calculating click target (Closed)

Created:
3 years, 9 months ago by johnme
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Ignore pointer capture target while calculating click target (patchset #1 id:1 of https://codereview.chromium.org/2764813004/ ) Reason for revert: Reverting didn't fix https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/7242 so this patch seems innocent. Original issue's description: > Revert of Ignore pointer capture target while calculating click target (patchset #1 id:1 of https://codereview.chromium.org/2755753003/ ) > > Reason for revert: > Tentative revert. Hit testing broke in the following tests, and this patch looks the most closely related: > > AccessibilityHitTestingBrowserTest.HitTestingInIframes > AccessibilityHitTestingBrowserTest.CachingAsyncHitTestingInIframes > > Original issue's description: > > Ignore pointer capture target while calculating click target > > > > After https://codereview.chromium.org/2681443003 > > it turns out we are creating some regressions. > > So this change keeps the essence of the original > > change for the purpose of keeping the metric but > > ignores the target that is calculated from the > > captured target and use the original click target > > regardless of the capturing. > > > > BUG=701599, 699933 > > > > Review-Url: https://codereview.chromium.org/2755753003 > > Cr-Commit-Position: refs/heads/master@{#458091} > > Committed: https://chromium.googlesource.com/chromium/src/+/ddb951c0cc2912acd57e4238677b82e6360ac1ad > > TBR=dtapuska@chromium.org,mustaq@chromium.org,bokan@chromium.org,nzolghadr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=701599, 699933 > > Review-Url: https://codereview.chromium.org/2764813004 > Cr-Commit-Position: refs/heads/master@{#458382} > Committed: https://chromium.googlesource.com/chromium/src/+/38052ae353aee8c943b570b5a2c10be82a48c1ae TBR=dtapuska@chromium.org,mustaq@chromium.org,bokan@chromium.org,nzolghadr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701599, 699933 Review-Url: https://codereview.chromium.org/2765683003 Cr-Commit-Position: refs/heads/master@{#458431} Committed: https://chromium.googlesource.com/chromium/src/+/4b4080856b160e1abf3c3a21cacdd165847d90d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_click_during_capture-manual-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 chunk +23 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
johnme
Created Reland of Ignore pointer capture target while calculating click target
3 years, 9 months ago (2017-03-21 16:22:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765683003/1
3 years, 9 months ago (2017-03-21 16:22:34 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 16:24:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b4080856b160e1abf3c3a21cacd...

Powered by Google App Engine
This is Rietveld 408576698