Move and rename Chrome's AppLauncherId to ash::AppLaunchId.

Move and rename Chrome's AppLauncherId to ash::AppLaunchId.

In preparation for use by ash::ShelfItem, etc.

Use tools/git/move_source_file.py to move and rename the files.
Use "git grep" and multi-file search/replace to rename identifiers.
Update the comments in app_launch_id.h

BUG=557406
TEST=Compiles, no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2765563002
Cr-Commit-Position: refs/heads/master@{#458224}
Committed: https://chromium.googlesource.com/chromium/src/+/812d4a2a764352251eda0a18f34434aefa9f0429

[msw, 2017-03-20 19:30:49]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:31:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-03-20 20:13:14]

Description was changed from

==========
Move and rename Chrome's AppLauncherId to Ash's AppLaunchId.

BUG=
==========

to

==========
Move and rename Chrome's AppLauncherId to ash::AppLaunchId.

In preparation for use by ash::ShelfItem, etc.

Use tools/git/move_source_file.py to move and rename the files.
Use "git grep" and multi-file search/replace to rename identifiers.
Update the comments in app_launch_id.h

BUG=557406
TEST=Compiles, no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2017-03-20 20:13:14]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2017-03-20 20:18:08]

Hey James, please take a look; thanks!
Hey Yury, just FYI, but feel free to review.

[James Cook, 2017-03-20 20:31:13]

LGTM with nit.

https://codereview.chromium.org/2765563002/diff/20001/ash/public/cpp/app_laun...
File ash/public/cpp/app_launch_id.h (right):

https://codereview.chromium.org/2765563002/diff/20001/ash/public/cpp/app_laun...
ash/public/cpp/app_launch_id.h:17: class ASH_PUBLIC_EXPORT AppLaunchId {
nit: could you add to this comment something like ", for example to support a
remote desktop client that wants each remote application to have its own icon".

Otherwise it's a little confusing why this feature exists.

https://codereview.chromium.org/2765563002/diff/20001/ash/public/cpp/app_laun...
ash/public/cpp/app_launch_id.h:35: std::string app_id_;
could these be const?

[msw, 2017-03-20 21:20:59]

https://codereview.chromium.org/2765563002/diff/20001/ash/public/cpp/app_laun...
File ash/public/cpp/app_launch_id.h (right):

https://codereview.chromium.org/2765563002/diff/20001/ash/public/cpp/app_laun...
ash/public/cpp/app_launch_id.h:17: class ASH_PUBLIC_EXPORT AppLaunchId {
On 2017/03/20 20:31:13, James Cook wrote:
> nit: could you add to this comment something like ", for example to support a
> remote desktop client that wants each remote application to have its own
icon".
> 
> Otherwise it's a little confusing why this feature exists.

Done.

https://codereview.chromium.org/2765563002/diff/20001/ash/public/cpp/app_laun...
ash/public/cpp/app_launch_id.h:35: std::string app_id_;
On 2017/03/20 20:31:13, James Cook wrote:
> could these be const?

No, unfortunately that seems to break copy constructor usage.

[msw, 2017-03-20 21:21:03]

The CQ bit was checked by msw@chromium.org

[msw, 2017-03-20 21:21:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2765563002/#ps40001
(title: "Add example commment.")

[commit-bot: I haz the power, 2017-03-20 21:21:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:10:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490044863752800,
"parent_rev": "c3bb5991a5b4cc6b632b1fe1d9368469826f5f30", "commit_rev":
"812d4a2a764352251eda0a18f34434aefa9f0429"}

[commit-bot: I haz the power, 2017-03-20 23:11:10]

Description was changed from

==========
Move and rename Chrome's AppLauncherId to ash::AppLaunchId.

In preparation for use by ash::ShelfItem, etc.

Use tools/git/move_source_file.py to move and rename the files.
Use "git grep" and multi-file search/replace to rename identifiers.
Update the comments in app_launch_id.h

BUG=557406
TEST=Compiles, no behavior changes.
R=jamescook@chromium.org
==========

to

==========
Move and rename Chrome's AppLauncherId to ash::AppLaunchId.

In preparation for use by ash::ShelfItem, etc.

Use tools/git/move_source_file.py to move and rename the files.
Use "git grep" and multi-file search/replace to rename identifiers.
Update the comments in app_launch_id.h

BUG=557406
TEST=Compiles, no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2765563002
Cr-Commit-Position: refs/heads/master@{#458224}
Committed:
https://chromium.googlesource.com/chromium/src/+/812d4a2a764352251eda0a18f344...
==========

[commit-bot: I haz the power, 2017-03-20 23:11:11]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/812d4a2a764352251eda0a18f344...