Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: ash/public/cpp/app_launch_id.h

Issue 2765563002: Move and rename Chrome's AppLauncherId to ash::AppLaunchId. (Closed)
Patch Set: Use ASH_PUBLIC_EXPORT. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/public/cpp/BUILD.gn ('k') | ash/public/cpp/app_launch_id.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_
6 #define ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_
7
8 #include <string>
9
10 #include "ash/public/cpp/ash_public_export.h"
11
12 namespace ash {
13
14 // A unique shelf item id composed of an |app_id| and a |launch_id|.
15 // |app_id| is the non-empty application id associated with a set of windows.
16 // |launch_id| is passed on app launch, to support multiple shelf items per app.
17 class ASH_PUBLIC_EXPORT AppLaunchId {
James Cook 2017/03/20 20:31:13 nit: could you add to this comment something like
msw 2017/03/20 21:20:59 Done.
18 public:
19 AppLaunchId(const std::string& app_id, const std::string& launch_id);
20 // Creates an AppLaunchId with an empty |launch_id|.
21 explicit AppLaunchId(const std::string& app_id);
22 // Empty constructor for pre-allocating.
23 AppLaunchId();
24 ~AppLaunchId();
25
26 AppLaunchId(const AppLaunchId& app_launch_id) = default;
27 AppLaunchId(AppLaunchId&& app_launch_id) = default;
28 AppLaunchId& operator=(const AppLaunchId& other) = default;
29
30 const std::string& app_id() const { return app_id_; }
31 const std::string& launch_id() const { return launch_id_; }
32
33 private:
34 // The application id associated with a set of windows.
35 std::string app_id_;
James Cook 2017/03/20 20:31:13 could these be const?
msw 2017/03/20 21:20:59 No, unfortunately that seems to break copy constru
36 // An id passed on app launch, to support multiple shelf items per app.
37 std::string launch_id_;
38 };
39
40 } // namespace ash
41
42 #endif // ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_
OLDNEW
« no previous file with comments | « ash/public/cpp/BUILD.gn ('k') | ash/public/cpp/app_launch_id.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698