[interpreter] Split bytecode generation out of interpreter.cc

[interpreter] Split bytecode generation out of interpreter.cc

as InterpreterGenerator. This is in preparation for no longer including
the bytecode handler generation code in the main library.

BUG=v8:6055
Review-Url: https://codereview.chromium.org/2765433003
Cr-Commit-Position: refs/heads/master@{#43949}
Committed: https://chromium.googlesource.com/v8/v8/+/221dec328f9f9046d09a4553c2f953bb42d0aad6

[Jakob Kummerow, 2017-03-20 14:30:00]

jkummerow@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Jakob Kummerow, 2017-03-20 14:30:00]

PTAL.

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
File src/interpreter/interpreter-generator.cc (right):

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter-generator.cc:41: private:
All these declarations are moved from interpreter.h

[rmcilroy, 2017-03-20 15:51:42]

Couple of nits, but LGTM, thanks.

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
File src/interpreter/interpreter-generator.cc (right):

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter-generator.cc:24: 
nit - remove extra newline

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
File src/interpreter/interpreter-generator.h (right):

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter-generator.h:6: #define
V8_INTERPRETER_INTERPRETERGENERATOR_H_
nit -  V8_INTERPRETER_INTERPRETER_GENERATOR_H_

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:15: #include "src/factory.h"
are debug.h and factory.h unneeded now?

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:16: #include "src/ic/accessor-assembler.h"
unneeded?

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:22: #include "src/zone/zone.h"
I think you can also probably drop zone.h and possibly objects-inl now too?

[Jakob Kummerow, 2017-03-20 16:31:01]

Thanks for the review, landing.

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
File src/interpreter/interpreter-generator.cc (right):

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter-generator.cc:24: 
On 2017/03/20 15:51:41, rmcilroy wrote:
> nit - remove extra newline

Done.

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
File src/interpreter/interpreter-generator.h (right):

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter-generator.h:6: #define
V8_INTERPRETER_INTERPRETERGENERATOR_H_
On 2017/03/20 15:51:41, rmcilroy wrote:
> nit -  V8_INTERPRETER_INTERPRETER_GENERATOR_H_

Done.

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:15: #include "src/factory.h"
On 2017/03/20 15:51:41, rmcilroy wrote:
> are debug.h and factory.h unneeded now?

Done.

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:16: #include "src/ic/accessor-assembler.h"
On 2017/03/20 15:51:41, rmcilroy wrote:
> unneeded?

Yes, forgot to delete it. Done.

https://codereview.chromium.org/2765433003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:22: #include "src/zone/zone.h"
On 2017/03/20 15:51:41, rmcilroy wrote:
> I think you can also probably drop zone.h and possibly objects-inl now too? 

Done.

[Jakob Kummerow, 2017-03-20 16:31:11]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-03-20 16:31:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2765433003/#ps20001
(title: "addressed nits")

[commit-bot: I haz the power, 2017-03-20 16:31:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 16:56:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490027471005200,
"parent_rev": "ec37d0b0f356b3e495208d4d34cbc6b770ccb583", "commit_rev":
"221dec328f9f9046d09a4553c2f953bb42d0aad6"}

[commit-bot: I haz the power, 2017-03-20 16:56:12]

Description was changed from

==========
[interpreter] Split bytecode generation out of interpreter.cc

as InterpreterGenerator. This is in preparation for no longer including
the bytecode handler generation code in the main library.

BUG=v8:6055
==========

to

==========
[interpreter] Split bytecode generation out of interpreter.cc

as InterpreterGenerator. This is in preparation for no longer including
the bytecode handler generation code in the main library.

BUG=v8:6055

Review-Url: https://codereview.chromium.org/2765433003
Cr-Commit-Position: refs/heads/master@{#43949}
Committed:
https://chromium.googlesource.com/v8/v8/+/221dec328f9f9046d09a4553c2f953bb42d...
==========

[commit-bot: I haz the power, 2017-03-20 16:56:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/221dec328f9f9046d09a4553c2f953bb42d...