Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2760953002: [builtins] Move more files into v8_builtins_generators source set (Closed)

Created:
3 years, 9 months ago by Jakob Kummerow
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move more files into v8_builtins_generators source set BUG=v8:6055 Review-Url: https://codereview.chromium.org/2760953002 Cr-Commit-Position: refs/heads/master@{#43975} Committed: https://chromium.googlesource.com/v8/v8/+/f8c707305b6416e9a451095159b00b8b44c4ddb1

Patch Set 1 #

Patch Set 2 : fix cctests #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -436 lines) Patch
M BUILD.gn View 1 2 17 chunks +56 lines, -21 lines 0 comments Download
M src/ast/ast.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D src/builtins/builtins-arguments.h View 1 chunk +0 lines, -55 lines 0 comments Download
A + src/builtins/builtins-arguments-gen.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/builtins/builtins-arguments-gen.cc View 1 chunk +2 lines, -1 line 0 comments Download
D src/builtins/builtins-async.h View 1 chunk +0 lines, -35 lines 0 comments Download
M src/builtins/builtins-async-function-gen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/builtins/builtins-async-gen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-async-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-async-iterator-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-constructor.h View 2 chunks +21 lines, -33 lines 0 comments Download
A + src/builtins/builtins-constructor-gen.h View 4 chunks +6 lines, -18 lines 0 comments Download
M src/builtins/builtins-constructor-gen.cc View 8 chunks +7 lines, -30 lines 0 comments Download
D src/builtins/builtins-forin.h View 1 chunk +0 lines, -34 lines 0 comments Download
A + src/builtins/builtins-forin-gen.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/builtins/builtins-forin-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/builtins/builtins-promise.h View 1 chunk +0 lines, -145 lines 0 comments Download
A + src/builtins/builtins-promise-gen.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/builtins/builtins-promise-gen.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/builtins/builtins-regexp-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/interpreter/bytecode-flags.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/interpreter/interpreter-generator.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/v8.gyp View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Jakob Kummerow
Benedikt, please review src/compiler/. Ross, please review src/interpreter/. Jakob, please review everything else. This CL ...
3 years, 9 months ago (2017-03-20 16:57:45 UTC) #2
Benedikt Meurer
LGTM on compiler.
3 years, 9 months ago (2017-03-20 17:38:15 UTC) #3
rmcilroy
Interpreter/ LGTM
3 years, 9 months ago (2017-03-20 18:09:49 UTC) #4
jgruber
lgtm
3 years, 9 months ago (2017-03-21 08:20:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760953002/20001
3 years, 9 months ago (2017-03-21 09:09:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/19270) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-21 09:10:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760953002/40001
3 years, 9 months ago (2017-03-21 10:08:04 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 11:17:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/f8c707305b6416e9a451095159b00b8b44c...

Powered by Google App Engine
This is Rietveld 408576698