[interpreter] Split bytecode generation out of interpreter.cc

src/interpreter/interpreter.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_INTERPRETER_H_
 #define V8_INTERPRETER_INTERPRETER_H_
 
 #include <memory>
 
 // Clients of this interface shouldn't depend on lots of interpreter internals.
 // Do not include anything from src/interpreter other than
 // src/interpreter/bytecodes.h here!
 #include "src/base/macros.h"
 #include "src/builtins/builtins.h"
 #include "src/interpreter/bytecodes.h"
 #include "src/parsing/token.h"
 #include "src/runtime/runtime.h"
 
 namespace v8 {
 namespace internal {
 
 class Isolate;
 class Callable;
 class CompilationInfo;
 class CompilationJob;
 
-namespace compiler {
-class Node;
-}  // namespace compiler
-
 namespace interpreter {
 
 class InterpreterAssembler;
 
 class Interpreter {
  public:
   explicit Interpreter(Isolate* isolate);
   virtual ~Interpreter() {}
 
   // Initializes the interpreter dispatch table.
   void Initialize();
 
   // Returns the interrupt budget which should be used for the profiler counter.
   static int InterruptBudget();
 
   // Creates a compilation job which will generate bytecode for |info|.
   static CompilationJob* NewCompilationJob(CompilationInfo* info);
 
   // Return bytecode handler for |bytecode|.
   Code* GetBytecodeHandler(Bytecode bytecode, OperandScale operand_scale);
 
   // GC support.
   void IterateDispatchTable(ObjectVisitor* v);
 
   // Disassembler support (only useful with ENABLE_DISASSEMBLER defined).
-  void TraceCodegen(Handle<Code> code);
   const char* LookupNameOfBytecodeHandler(Code* code);
 
   V8_EXPORT_PRIVATE Local<v8::Object> GetDispatchCountersObject();
 
   Address dispatch_table_address() {
     return reinterpret_cast<Address>(&dispatch_table_[0]);
   }
 
   Address bytecode_dispatch_counters_table() {
     return reinterpret_cast<Address>(bytecode_dispatch_counters_table_.get());
   }
 
   // TODO(ignition): Tune code size multiplier.
   static const int kCodeSizeMultiplier = 32;
 
  private:
-// Bytecode handler generator functions.
-#define DECLARE_BYTECODE_HANDLER_GENERATOR(Name, ...) \
-  void Do##Name(InterpreterAssembler* assembler);
-  BYTECODE_LIST(DECLARE_BYTECODE_HANDLER_GENERATOR)
-#undef DECLARE_BYTECODE_HANDLER_GENERATOR
-
-  typedef void (Interpreter::*BytecodeGeneratorFunc)(InterpreterAssembler*);
-
   // In the case of bytecodes that share handler implementations, copy the code
   // into the bytecode's dispatcher table entry and return true.
   bool ReuseExistingHandler(Bytecode bytecode, OperandScale operand_scale);
 
-  // Generates handler for given |bytecode| and |operand_scale| using
-  // |generator| and installs it into the dispatch table.
-  void InstallBytecodeHandler(Zone* zone, Bytecode bytecode,
-                              OperandScale operand_scale,
-                              BytecodeGeneratorFunc generator);
-
-  // Generates code to perform the binary operation via |Generator|.
-  template <class Generator>
-  void DoBinaryOpWithFeedback(InterpreterAssembler* assembler);
-
-  // Generates code to perform the comparison via |Generator| while gathering
-  // type feedback.
-  void DoCompareOpWithFeedback(Token::Value compare_op,
-                               InterpreterAssembler* assembler);
-
-  // Generates code to perform the bitwise binary operation corresponding to
-  // |bitwise_op| while gathering type feedback.
-  void DoBitwiseBinaryOp(Token::Value bitwise_op,
-                         InterpreterAssembler* assembler);
-
-  // Generates code to perform the binary operation via |Generator| using
-  // an immediate value rather the accumulator as the rhs operand.
-  template <class Generator>
-  void DoBinaryOpWithImmediate(InterpreterAssembler* assembler);
-
-  // Generates code to perform the unary operation via |Generator| while
-  // gatering type feedback.
-  template <class Generator>
-  void DoUnaryOpWithFeedback(InterpreterAssembler* assembler);
-
-  // Generates code to perform the comparison operation associated with
-  // |compare_op|.
-  void DoCompareOp(Token::Value compare_op, InterpreterAssembler* assembler);
-
-  // Generates code to perform a global store via |ic|.
-  void DoStaGlobal(Callable ic, InterpreterAssembler* assembler);
-
-  // Generates code to perform a named property store via |ic|.
-  void DoStoreIC(Callable ic, InterpreterAssembler* assembler);
-
-  // Generates code to perform a keyed property store via |ic|.
-  void DoKeyedStoreIC(Callable ic, InterpreterAssembler* assembler);
-
-  // Generates code to perform a JS call that collects type feedback.
-  void DoJSCall(InterpreterAssembler* assembler, TailCallMode tail_call_mode);
-
-  // Generates code to perform a JS call with a known number of arguments that
-  // collects type feedback.
-  void DoJSCallN(InterpreterAssembler* assembler, int n);
-
-  // Generates code to perform delete via function_id.
-  void DoDelete(Runtime::FunctionId function_id,
-                InterpreterAssembler* assembler);
-
-  // Generates code to perform a lookup slot load via |function_id|.
-  void DoLdaLookupSlot(Runtime::FunctionId function_id,
-                       InterpreterAssembler* assembler);
-
-  // Generates code to perform a lookup slot load via |function_id| that can
-  // fast path to a context slot load.
-  void DoLdaLookupContextSlot(Runtime::FunctionId function_id,
-                              InterpreterAssembler* assembler);
-
-  // Generates code to perform a lookup slot load via |function_id| that can
-  // fast path to a global load.
-  void DoLdaLookupGlobalSlot(Runtime::FunctionId function_id,
-                             InterpreterAssembler* assembler);
-
-  // Generates code to perform a lookup slot store depending on
-  // |language_mode|.
-  void DoStaLookupSlot(LanguageMode language_mode,
-                       InterpreterAssembler* assembler);
-
-  // Generates code to load a global property.
-  void BuildLoadGlobalIC(int slot_operand_index, int name_operand_index,
-                         TypeofMode typeof_mode,
-                         InterpreterAssembler* assembler);
-
-  // Generates code to load a property.
-  void BuildLoadIC(int recv_operand_index, int slot_operand_index,
-                   int name_operand_index, InterpreterAssembler* assembler);
-
-  // Generates code to prepare the result for ForInPrepare. Cache data
-  // are placed into the consecutive series of registers starting at
-  // |output_register|.
-  void BuildForInPrepareResult(compiler::Node* output_register,
-                               compiler::Node* cache_type,
-                               compiler::Node* cache_array,
-                               compiler::Node* cache_length,
-                               InterpreterAssembler* assembler);
-
-  // Generates code to perform the unary operation via |callable|.
-  compiler::Node* BuildUnaryOp(Callable callable,
-                               InterpreterAssembler* assembler);
+  // Generates handler for given |bytecode| and |operand_scale|
+  // and installs it into the dispatch table.
+  void InstallBytecodeHandler(Isolate* isolate, Bytecode bytecode,
+                              OperandScale operand_scale);
 
   uintptr_t GetDispatchCounter(Bytecode from, Bytecode to) const;
 
   // Get dispatch table index of bytecode.
   static size_t GetDispatchTableIndex(Bytecode bytecode,
                                       OperandScale operand_scale);
 
   bool IsDispatchTableInitialized();
   bool ShouldInitializeDispatchTable();
 
   static const int kNumberOfWideVariants = 3;
   static const int kDispatchTableSize = kNumberOfWideVariants * (kMaxUInt8 + 1);
   static const int kNumberOfBytecodes = static_cast<int>(Bytecode::kLast) + 1;
 
   Isolate* isolate_;
   Address dispatch_table_[kDispatchTableSize];
   std::unique_ptr<uintptr_t[]> bytecode_dispatch_counters_table_;
 
   DISALLOW_COPY_AND_ASSIGN(Interpreter);
 };
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_INTERPRETER_H_