[WIP] Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker()

third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
@@ skipping 44 matching lines @@
   setContext(&document);
 }
 
 void DocumentMarkerController::clear() {
   for (DocumentMarker::MarkerType type : DocumentMarker::AllMarkers()) {
     MarkerMap& markerMap = markerMapForType(type);
     markerMap.clear();
   }
 }
 
-void DocumentMarkerController::addMarker(const Position& start,
-                                         const Position& end,
-                                         DocumentMarker::MarkerType type,
-                                         const String& description) {
+void DocumentMarkerController::addGrammarOrSpellingMarker(
+    const Position& start,
+    const Position& end,
+    DocumentMarker::MarkerType type,
+    const String& description) {
+  DCHECK(!m_document->needsLayoutTreeUpdate());
+  DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling);

[yosin_UTC9, 2017/03/30 01:48:57]

nit: Could you add |<< type| for ease of debugging?

   // Use a TextIterator to visit the potentially multiple nodes the range
   // covers.
   for (TextIterator markedText(start, end); !markedText.atEnd();
        markedText.advance()) {
     addMarker(markedText.currentContainer(),
               new SpellCheckMarker(
                   type, markedText.startOffsetInCurrentContainer(),
                   markedText.endOffsetInCurrentContainer(), description));
   }
 }
 
+void DocumentMarkerController::addSpellingMarker(const Position& start,
+                                                 const Position& end,
+                                                 const String& description) {
+  addGrammarOrSpellingMarker(start, end, DocumentMarker::Spelling, description);
+}
+
+void DocumentMarkerController::addGrammarMarker(const Position& start,
+                                                const Position& end,
+                                                const String& description) {
+  addGrammarOrSpellingMarker(start, end, DocumentMarker::Grammar, description);
+}
+
 void DocumentMarkerController::addTextMatchMarker(const EphemeralRange& range,
                                                   bool activeMatch) {
   DCHECK(!m_document->needsLayoutTreeUpdate());
 
   // Use a TextIterator to visit the potentially multiple nodes the range
   // covers.
   for (TextIterator markedText(range.startPosition(), range.endPosition());
        !markedText.atEnd(); markedText.advance()) {
     addMarker(markedText.currentContainer(),
               new TextMatchMarker(markedText.startOffsetInCurrentContainer(),
@@ skipping 496 matching lines @@
 }
 
 }  // namespace blink
 
 #ifndef NDEBUG
 void showDocumentMarkers(const blink::DocumentMarkerController* controller) {
   if (controller)
     controller->showMarkers();
 }
 #endif